<feature>[iam2]: add ZIAM provider name constant (P1)#3856
Open
zstack-robot-2 wants to merge 2 commits intofeature-5.5.22-zcf-temporaryfrom
Open
<feature>[iam2]: add ZIAM provider name constant (P1)#3856zstack-robot-2 wants to merge 2 commits intofeature-5.5.22-zcf-temporaryfrom
zstack-robot-2 wants to merge 2 commits intofeature-5.5.22-zcf-temporaryfrom
Conversation
Resolves: ZCF-3009 Change-Id: I734d872432d519d4a04fade5d24a9eee040f160f
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough在 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Add ZIAM_DEFAULT_SCOPE = "openid profile email" to OAuth2PluginConstants for use by IAM2RopcLoginBackend instead of hardcoded string. Resolves: ZCF-3009 Change-Id: I7638e4bb3231fa75b1ad3460863040d43970d9f5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P1 ZIAM OIDC ROPC 打通的父仓库部分:在
OAuth2PluginConstants中新增ZIAM_PROVIDER_NAME = "ziam"与LOGIN_TYPE_IAM2_ROPC = "iam2_ropc",作为OAuth2ClientVO.identityProvider的判别值和登录路由 loginType,与 premium 仓库侧的ZiamProvider/IAM2RopcLoginBackend配套。Resolves: ZCF-3009
Test plan
sync from gitlab !9728