<fix>[conf]: add ORG_ZSTACK_AI_10159 for model service startup timeout#3855
Open
ZStack-Robot wants to merge 1 commit into5.5.16from
Open
<fix>[conf]: add ORG_ZSTACK_AI_10159 for model service startup timeout#3855ZStack-Robot wants to merge 1 commit into5.5.16from
ZStack-Robot wants to merge 1 commit into5.5.16from
Conversation
Resolves: ZSTAC-84677 Allocate a dedicated error code for the "model service instance startup timeout" failure path in AIModelManagerImpl. Before this change, that path reused ORG_ZSTACK_AI_10144 (owned by VmModelMountManager for "mount path already used"), causing the UI to render the unrelated Chinese mount-conflict template with unfilled %s slots for a health-check timeout. - Declare ORG_ZSTACK_AI_10159 in CloudOperationsErrorCode - Add the Chinese localization in global-error-zh_CN.json
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Walkthrough在CloudOperationsErrorCode类中添加了一个新的公共常量错误代码标识符ORG_ZSTACK_AI_10159,用于扩展已定义的错误代码集合。 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.42.1)utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.javaComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: ZSTAC-84677
Paired with premium!13655.
Problem
AIModelManagerImpl model-service startup-timeout path reused
ORG_ZSTACK_AI_10144which is owned byVmModelMountManagerfor the mount path already used error. That code maps to a Chinese elaboration template with 5%sslots describing a mount conflict; the timeout only supplies 3 formatArgs (uuid / seconds / reason), so the UI rendered a garbled挂载失败:路径 <uuid> ... 所属虚拟机:%s 所属虚拟机UUID:%smessage for what was a health-check timeout.This MR (zstack side)
ORG_ZSTACK_AI_10159inCloudOperationsErrorCodeglobal-error-zh_CN.json: 推理服务实例(UUID: %s)启动超时(%s 秒),原因: %sCompanion (premium side)
AIModelManagerImpl:3178to useORG_ZSTACK_AI_10159via the star import ofCloudOperationsErrorCodeVerification
javacon JDK 8 with full zstack classpath compiles clean — confirmed updatedCloudOperationsErrorCodeexposesORG_ZSTACK_AI_10159, and premiumAIModelManagerImplcompiles against it cleanlyORG_ZSTACK_AI_10158commit (3936530, ZSTAC-83157) which is the repo precedent for adding new AI error codes (zh_CN only, no other locale)sync from gitlab !9727