Skip to content

<fix>[conf]: add ORG_ZSTACK_AI_10159 for model service startup timeout#3855

Open
ZStack-Robot wants to merge 1 commit into5.5.16from
sync/zhongqi.liu/fix/ZSTAC-84677
Open

<fix>[conf]: add ORG_ZSTACK_AI_10159 for model service startup timeout#3855
ZStack-Robot wants to merge 1 commit into5.5.16from
sync/zhongqi.liu/fix/ZSTAC-84677

Conversation

@ZStack-Robot
Copy link
Copy Markdown
Collaborator

Resolves: ZSTAC-84677

Paired with premium!13655.

Problem

AIModelManagerImpl model-service startup-timeout path reused ORG_ZSTACK_AI_10144 which is owned by VmModelMountManager for the mount path already used error. That code maps to a Chinese elaboration template with 5 %s slots describing a mount conflict; the timeout only supplies 3 formatArgs (uuid / seconds / reason), so the UI rendered a garbled 挂载失败:路径 <uuid> ... 所属虚拟机:%s 所属虚拟机UUID:%s message for what was a health-check timeout.

This MR (zstack side)

  • Declare new error code constant ORG_ZSTACK_AI_10159 in CloudOperationsErrorCode
  • Add Chinese localization in global-error-zh_CN.json: 推理服务实例(UUID: %s)启动超时(%s 秒),原因: %s

Companion (premium side)

  • premium!13655 switches the call site at AIModelManagerImpl:3178 to use ORG_ZSTACK_AI_10159 via the star import of CloudOperationsErrorCode

Verification

  • javac on JDK 8 with full zstack classpath compiles clean — confirmed updated CloudOperationsErrorCode exposes ORG_ZSTACK_AI_10159, and premium AIModelManagerImpl compiles against it cleanly
  • Pattern matches the preceding ORG_ZSTACK_AI_10158 commit (3936530, ZSTAC-83157) which is the repo precedent for adding new AI error codes (zh_CN only, no other locale)

sync from gitlab !9727

Resolves: ZSTAC-84677

Allocate a dedicated error code for the "model service instance startup
timeout" failure path in AIModelManagerImpl. Before this change, that
path reused ORG_ZSTACK_AI_10144 (owned by VmModelMountManager for "mount
path already used"), causing the UI to render the unrelated Chinese
mount-conflict template with unfilled %s slots for a health-check
timeout.

- Declare ORG_ZSTACK_AI_10159 in CloudOperationsErrorCode
- Add the Chinese localization in global-error-zh_CN.json
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: a6bd59b4-0716-49f3-be05-ae3b57772c52

📥 Commits

Reviewing files that changed from the base of the PR and between c096635 and 378b2be.

⛔ Files ignored due to path filters (1)
  • conf/i18n/globalErrorCodeMapping/global-error-zh_CN.json is excluded by !**/*.json
📒 Files selected for processing (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Walkthrough

在CloudOperationsErrorCode类中添加了一个新的公共常量错误代码标识符ORG_ZSTACK_AI_10159,用于扩展已定义的错误代码集合。

Changes

Cohort / File(s) 摘要
错误代码常量
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
添加新的公共静态最终字符串常量ORG_ZSTACK_AI_10159,用作错误代码标识符。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 一个常量悄悄添加,
错误代码又增一章,
简洁如我的小萝卜,
变更来得轻飘飘~

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题完全符合指定格式([scope]: )且长度为70个字符,在72字符限制内。
Description check ✅ Passed 描述与变更集紧密相关,详细说明了问题背景、解决方案和验证方法。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/zhongqi.liu/fix/ZSTAC-84677

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.42.1)
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants