Skip to content

<fix>[aios]: add i18n mappings for fatal image pull error#3800

Open
zstack-robot-1 wants to merge 1 commit into5.5.16from
sync/chao.he/fix/ZSTAC-84175-TIPS-@@2
Open

<fix>[aios]: add i18n mappings for fatal image pull error#3800
zstack-robot-1 wants to merge 1 commit into5.5.16from
sync/chao.he/fix/ZSTAC-84175-TIPS-@@2

Conversation

@zstack-robot-1
Copy link
Copy Markdown
Collaborator

  • add dedicated container image pull error code mapping
  • keep generic deployment failure message for 10039

Resolves: ZSTAC-84175
Change-Id: Iabcdef1234567890abcdef1234567890abcdef12

sync from gitlab !9670

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 103d9b8f-2522-4878-81ac-5ae5efb1ed14

📥 Commits

Reviewing files that changed from the base of the PR and between 91094d3 and 80ddd20.

⛔ Files ignored due to path filters (2)
  • conf/i18n/globalErrorCodeMapping/global-error-en_US.json is excluded by !**/*.json
  • conf/i18n/globalErrorCodeMapping/global-error-zh_CN.json is excluded by !**/*.json
📒 Files selected for processing (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Walkthrough

CloudOperationsErrorCode 类中新增了一个导出常量 ORG_ZSTACK_CONTAINER_10057,其字符串值为 "ORG_ZSTACK_CONTAINER_10057";未修改其他逻辑或控制流。

Changes

Cohort / File(s) Summary
错误代码常量
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
新增公共静态常量 ORG_ZSTACK_CONTAINER_10057 = "ORG_ZSTACK_CONTAINER_10057"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 新码轻轻落一行,
名为容器的微光,
七字编号成新章,
在库中静静躺,
我蹦跳着为它歌唱。

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed 标题遵循了required的格式([scope]: )且长度为57字符,在72字符限制内。标题内容与changeset一致。
Description check ✅ Passed 描述与changeset相关,说明了添加容器镜像拉取错误代码映射和保留通用部署失败消息的目的。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/chao.he/fix/ZSTAC-84175-TIPS-@@2

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.42.1)
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Comment @coderabbitai help to get the list of available commands and usage tips.

@MatheMatrix MatheMatrix force-pushed the sync/chao.he/fix/ZSTAC-84175-TIPS-@@2 branch 3 times, most recently from 6542eff to 62fc938 Compare April 20, 2026 08:50
- add dedicated container image pull error code mapping

Resolves: ZSTAC-84175

Change-Id: Iabcdef1234567890abcdef1234567890abcdef12
@MatheMatrix MatheMatrix force-pushed the sync/chao.he/fix/ZSTAC-84175-TIPS-@@2 branch from 62fc938 to 80ddd20 Compare April 20, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant