Fix: properly render emoji in usernames, mentions, and roles; restore role mention colors.#337
Open
ohmwraith wants to merge 3 commits intoMathMan05:mainfrom
Open
Fix: properly render emoji in usernames, mentions, and roles; restore role mention colors.#337ohmwraith wants to merge 3 commits intoMathMan05:mainfrom
ohmwraith wants to merge 3 commits intoMathMan05:mainfrom
Conversation
ohmwraith
force-pushed
the
fix/restore-emoji-colors-in-nick
branch
from
79b8978 to
6ebc37f
Compare
ohmwraith
force-pushed
the
fix/restore-emoji-colors-in-nick
branch
from
6ebc37f to
b6eca7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect emoji rendering in usernames, role names, and mentions by properly handling Unicode grapheme clusters.
Previously, emoji could inherit role background colors, resulting in incorrect appearance.
Also restores correct role mention colors.
Usage
A new utility function,
setTextWithWrappedEmoji, replaces plain text rendering with grapheme-aware rendering.It splits the string into grapheme clusters and wraps emoji in
<span class="emoji">.Use it wherever user-provided names or mentions are rendered (usernames, role names, channel mentions, etc.).
Notes
Intl.Segmenteris used for correct Unicode handling, falls back to the previous behavior in unsupported browsers.Chat
Before
After
Member List
Server roles