Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 75 75
Lines 5032 5034 +2
=======================================
+ Hits 4557 4559 +2
Misses 475 475
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@ml-evs if these updates are good for you, please merge :) |
Member
Wow, I haven't kept up with all this starlette drama... the fix looks and works fine, will just have to keep an eye on how FastAPI want to manage this deprecation. |
Bumps the python-dependencies group with 17 updates in the / directory: | Package | From | To | | --- | --- | --- | | [pydantic](https://github.com/pydantic/pydantic) | `2.12.5` | `2.13.3` | | [pydantic-settings](https://github.com/pydantic/pydantic-settings) | `2.12.0` | `2.14.0` | | [requests](https://github.com/psf/requests) | `2.32.5` | `2.33.1` | | [elasticsearch](https://github.com/elastic/elasticsearch-py) | `7.17.12` | `7.17.13` | | [pymongo](https://github.com/mongodb/mongo-python-driver) | `4.15.5` | `4.17.0` | | [uvicorn](https://github.com/Kludex/uvicorn) | `0.40.0` | `0.45.0` | | [fastapi](https://github.com/fastapi/fastapi) | `0.127.0` | `0.136.0` | | [starlette](https://github.com/Kludex/starlette) | `0.50.0` | `1.0.0` | | [aiida-core](https://github.com/aiidateam/aiida-core) | `2.7.2` | `2.8.0` | | [rich](https://github.com/Textualize/rich) | `14.2.0` | `15.0.0` | | [ase](https://gitlab.com/ase/ase) | `3.26.0` | `3.28.0` | | [mike](https://github.com/jimporter/mike) | `2.1.3` | `2.2.0` | | [mkdocs-autorefs](https://github.com/mkdocstrings/autorefs) | `1.4.3` | `1.4.4` | | [mkdocs-material](https://github.com/squidfunk/mkdocs-material) | `9.7.1` | `9.7.6` | | [mkdocstrings](https://github.com/mkdocstrings/mkdocstrings) | `1.0.0` | `1.0.4` | | [griffe](https://github.com/mkdocstrings/griffe) | `1.15.0` | `2.0.2` | | [jarvis-tools](https://github.com/atomgptlab/jarvis-tools) | `2025.5.30` | `2026.4.2` | Updates `pydantic` from 2.12.5 to 2.13.3 - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v2.12.5...v2.13.3) Updates `pydantic-settings` from 2.12.0 to 2.14.0 - [Release notes](https://github.com/pydantic/pydantic-settings/releases) - [Commits](pydantic/pydantic-settings@v2.12.0...v2.14.0) Updates `requests` from 2.32.5 to 2.33.1 - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.5...v2.33.1) Updates `elasticsearch` from 7.17.12 to 7.17.13 - [Release notes](https://github.com/elastic/elasticsearch-py/releases) - [Commits](https://github.com/elastic/elasticsearch-py/commits) Updates `pymongo` from 4.15.5 to 4.17.0 - [Release notes](https://github.com/mongodb/mongo-python-driver/releases) - [Changelog](https://github.com/mongodb/mongo-python-driver/blob/master/doc/changelog.rst) - [Commits](mongodb/mongo-python-driver@4.15.5...4.17.0) Updates `uvicorn` from 0.40.0 to 0.45.0 - [Release notes](https://github.com/Kludex/uvicorn/releases) - [Changelog](https://github.com/Kludex/uvicorn/blob/main/docs/release-notes.md) - [Commits](Kludex/uvicorn@0.40.0...0.45.0) Updates `fastapi` from 0.127.0 to 0.136.0 - [Release notes](https://github.com/fastapi/fastapi/releases) - [Commits](fastapi/fastapi@0.127.0...0.136.0) Updates `starlette` from 0.50.0 to 1.0.0 - [Release notes](https://github.com/Kludex/starlette/releases) - [Changelog](https://github.com/Kludex/starlette/blob/main/docs/release-notes.md) - [Commits](Kludex/starlette@0.50.0...1.0.0) Updates `aiida-core` from 2.7.2 to 2.8.0 - [Release notes](https://github.com/aiidateam/aiida-core/releases) - [Changelog](https://github.com/aiidateam/aiida-core/blob/main/CHANGELOG.md) - [Commits](aiidateam/aiida-core@v2.7.2...v2.8.0) Updates `rich` from 14.2.0 to 15.0.0 - [Release notes](https://github.com/Textualize/rich/releases) - [Changelog](https://github.com/Textualize/rich/blob/master/CHANGELOG.md) - [Commits](Textualize/rich@v14.2.0...v15.0.0) Updates `ase` from 3.26.0 to 3.28.0 - [Changelog](https://gitlab.com/ase/ase/blob/master/CHANGELOG.rst) - [Commits](https://gitlab.com/ase/ase/compare/3.26.0...3.28.0) Updates `mike` from 2.1.3 to 2.2.0 - [Release notes](https://github.com/jimporter/mike/releases) - [Changelog](https://github.com/jimporter/mike/blob/master/CHANGES.md) - [Commits](jimporter/mike@v2.1.3...v2.2.0) Updates `mkdocs-autorefs` from 1.4.3 to 1.4.4 - [Release notes](https://github.com/mkdocstrings/autorefs/releases) - [Changelog](https://github.com/mkdocstrings/autorefs/blob/main/CHANGELOG.md) - [Commits](mkdocstrings/autorefs@1.4.3...1.4.4) Updates `mkdocs-material` from 9.7.1 to 9.7.6 - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.7.1...9.7.6) Updates `mkdocstrings` from 1.0.0 to 1.0.4 - [Release notes](https://github.com/mkdocstrings/mkdocstrings/releases) - [Changelog](https://github.com/mkdocstrings/mkdocstrings/blob/main/CHANGELOG.md) - [Commits](mkdocstrings/mkdocstrings@1.0.0...1.0.4) Updates `griffe` from 1.15.0 to 2.0.2 - [Release notes](https://github.com/mkdocstrings/griffe/releases) - [Changelog](https://github.com/mkdocstrings/griffe/blob/main/CHANGELOG.md) - [Commits](mkdocstrings/griffe@1.15.0...2.0.2) Updates `jarvis-tools` from 2025.5.30 to 2026.4.2 - [Release notes](https://github.com/atomgptlab/jarvis-tools/releases) - [Commits](https://github.com/atomgptlab/jarvis-tools/commits/v2026.4.2) --- updated-dependencies: - dependency-name: pydantic dependency-version: 2.13.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: pydantic-settings dependency-version: 2.14.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: requests dependency-version: 2.33.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: elasticsearch dependency-version: 7.17.13 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: python-dependencies - dependency-name: pymongo dependency-version: 4.17.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: uvicorn dependency-version: 0.45.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: fastapi dependency-version: 0.136.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: starlette dependency-version: 1.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: python-dependencies - dependency-name: aiida-core dependency-version: 2.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: rich dependency-version: 15.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: python-dependencies - dependency-name: ase dependency-version: 3.28.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: mike dependency-version: 2.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: python-dependencies - dependency-name: mkdocs-autorefs dependency-version: 1.4.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: python-dependencies - dependency-name: mkdocs-material dependency-version: 9.7.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: python-dependencies - dependency-name: mkdocstrings dependency-version: 1.0.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: python-dependencies - dependency-name: griffe dependency-version: 2.0.2 dependency-type: direct:production update-type: version-update:semver-major dependency-group: python-dependencies - dependency-name: jarvis-tools dependency-version: 2026.4.2 dependency-type: direct:production update-type: version-update:semver-major dependency-group: python-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
The landing page Router is taken directly from Starlette, instead of via FastAPI's APIRouter implementation. This leads to an issue with the, now deprecated, implementation of events (on_startup, on_shutdown), which are still checked for and expected when FastAPI includes routers in other routers or its application. I've just copied over the workaround FastAPI itself have implemented in the init-method of APIRouter.
bc6a316 to
55b1305
Compare
ml-evs
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the python-dependencies group with 17 updates in the / directory:
2.12.52.13.32.12.02.14.02.32.52.33.17.17.127.17.134.15.54.17.00.40.00.45.00.127.00.136.00.50.01.0.02.7.22.8.014.2.015.0.03.26.03.28.02.1.32.2.01.4.31.4.49.7.19.7.61.0.01.0.41.15.02.0.22025.5.302026.4.2Updates
pydanticfrom 2.12.5 to 2.13.3Release notes
Sourced from pydantic's releases.
... (truncated)
Changelog
Sourced from pydantic's changelog.
... (truncated)
Commits
9e9a111Fix backported test1ec8c6aPrepare release v2.13.3fb4f204HandleAttributeErrorsubclasses withfrom_attributesca3ddd1Prepare release v2.13.2000e823FixValidationInfo.field_namemissing withmodel_validate_json()d45d8bePrepare release 2.13.154aca60FixValidationInfo.datamissing withmodel_validate_json()46bf4faFix Pydantic release workflow (#13067)1b359edPrepare release v2.13.0 (#13065)b1bf194Fix model equality when using runtimeextraconfiguration (#13062)Updates
pydantic-settingsfrom 2.12.0 to 2.14.0Release notes
Sourced from pydantic-settings's releases.
... (truncated)
Commits
8916beePrepare release 2.14.0 (#848)39e551cFix CLI descriptions lost underpython -OOby falling back to `json_schema_...9ed7f48Bump the python-packages group with 4 updates (#847)617c690Fixcli_ignore_unknown_args=Truenot working on subcommands (#844)577c05fAdd note about Mypy plugin forBaseSettings.__init__()(#842)2355bc5Fix CliPositionalArg[list[CustomType]] crash for custom types (#839)16bd6fdIntroduce zizmor (#838)df8b239Bump boto3 from 1.42.82 to 1.42.83 in the python-packages group (#837)c5401a2Introduce yamlfmt (#836)953e28eBump the python-packages group with 3 updates (#833)Updates
requestsfrom 2.32.5 to 2.33.1Release notes
Sourced from requests's releases.
Changelog
Sourced from requests's changelog.
Commits
111d2b7v2.33.1f0198e6Fix malformed value parsing for Content-Type (#7309)bc7dd0fFix cosmetic header validity parsing regex (#7308)4443b1aFix unintended test extra (#7306)389eea5Cleanup extracted file after extract_zipped_path test (#7305)7407309Packaging: DRY out extras definition (#7277)bc04dfdv2.33.066d21cbMerge commit from fork8b9bc8fMove badges to top of README (#7293)e331a28Remove unused extraction call (#7292)Updates
elasticsearchfrom 7.17.12 to 7.17.13Commits
Updates
pymongofrom 4.15.5 to 4.17.0Release notes
Sourced from pymongo's releases.
... (truncated)
Changelog
Sourced from pymongo's changelog.
Commits
f2103a9Prep branch v4.173491c08PYTHON-5801 - Update changelog for 4.17 release (#2762)912ef33PYTHON-5798 - Overload retargeting prose tests do not ensure that sec… (#2760)b4e2c03PYTHON-5800 - Simple collation is included in index information (#2761)f31ba09PYTHON-5797 - Add IWM and Overload Error links to changelog (#2757)5da9183PYTHON-5794 - Add prose tests to verify correct retry behavior when a… (#2755)35e51a5Revert "PYTHON-5768 Add AGENTS.md w/copilot instructions" (#2744) (#2754)f41dd5cPYTHON-5772 Increase _gcp_helpers.py coverage (#2749)49e7a05PYTHON-5760 Increase _azure_helpers.py coverage (#2747)a2b0cd8PYTHON-5795 Fix absolute link to CONTRIBUTING.md in README.md (#2756)Updates
uvicornfrom 0.40.0 to 0.45.0Release notes
Sourced from uvicorn's releases.
... (truncated)
Changelog
Sourced from uvicorn's changelog.
... (truncated)
Commits
2c423bdVersion 0.45.0 (#2914)7f027f8Revert "Emithttp.disconnecton server shutdown for streaming responses" (#...73a80c3Add--reset-contextvarsflag to isolate ASGI request context (#2912)45c0b56Revert empty context for ASGI runs (#2911)850d926Raise helpfulImportErrorwhen PyYAML is missing for YAML log config (#2906)fdcacb4Acceptlog_levelstrings case-insensitively (#2907)70f247fAcceptos.PathLikeforlog_config(#2905)18edfa7Preserve forwarded client ports in proxy headers middleware (#2903)77843e0Stabilize websocket keepalive ping test (#2904)3703339chore(deps-dev): bump pytest from 9.0.2 to 9.0.3 (#2902)Updates
fastapifrom 0.127.0 to 0.136.0Release notes
Sourced from fastapi's releases.