Skip to content

feat(provider): ✨ Add ZenMux promo banner#73

Merged
jorben merged 1 commit into
masterfrom
feat/provider-ui-updates
May 13, 2026
Merged

feat(provider): ✨ Add ZenMux promo banner#73
jorben merged 1 commit into
masterfrom
feat/provider-ui-updates

Conversation

@jorben
Copy link
Copy Markdown
Collaborator

@jorben jorben commented May 13, 2026

Summary

  • Add a ZenMux promotion banner to the Provider settings page between API URL and model configuration.
  • Add localized banner copy for all supported provider locales.
  • Add styling and renderer test coverage for the banner and external CTA link.

Test Plan

  • npm run test:renderer -- Provider.test.tsx
  • npm run typecheck

🤖 Generated with TiyCode

@github-actions
Copy link
Copy Markdown

AI Code Review Summary

PR: #73 (feat(provider): ✨ Add ZenMux promo banner)
Preferred language: English

Overall Assessment

Detected 1 actionable findings, prioritize CRITICAL/HIGH before merge.

Major Findings by Severity

  • LOW (1)
    • src/renderer/components/Provider.tsx:504 - Hardcoded external referral link

Actionable Suggestions

Potential Risks

  • Potential hidden risks remain in edge cases not covered by the current diff context.

Test Suggestions

  • Add happy-path + boundary + failure-path tests for touched modules.

File-Level Coverage Notes

  • src/renderer/components/Provider.tsx: ok (Addition of ad banner is clean, but consider externalizing the URL.)
  • src/renderer/components/tests/Provider.test.tsx: ok (Test covers the ad banner appearance and link attributes.)
  • src/renderer/locales/ar-SA/provider.json: ok (Translation entries added correctly.)
  • src/renderer/locales/en-US/provider.json: ok (Translation entries added correctly.)
  • src/renderer/locales/fa-IR/provider.json: ok (Translation entries added correctly.)
  • src/renderer/locales/ja-JP/provider.json: ok (Translation entries added correctly.)
  • src/renderer/locales/ru-RU/provider.json: ok (Translation entries added correctly.)
  • src/renderer/locales/zh-CN/provider.json: ok (Translation entries added correctly.)

Inline Downgraded Items (processed but not inline)

  • None

Coverage Status

  • Target files: 8
  • Covered files: 8
  • Uncovered files: 0
  • No-patch/binary covered as file-level: 0
  • Findings with unknown confidence (N/A): 0

Uncovered list:

  • None

No-patch covered list:

  • None

Runtime/Budget

  • Rounds used: 1/4
  • Planned batches: 1
  • Executed batches: 1
  • Sub-agent runs: 1
  • Planner calls: 1
  • Reviewer calls: 1
  • Model calls: 2/64
  • Structured-output summary-only degradation: NO

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR review completed.

  • Findings kept: 1
  • Findings with unknown confidence: 0
  • Inline comments attempted: 1
  • Target files: 8
  • Covered files: 8
  • Uncovered files: 0
    See the summary comment for detailed analysis and coverage details.

</div>
<a
className="provider-ad-banner__link"
href="https://zenmux.ai/invite/9H70CU"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Hardcoded external referral link

The advertisement link is a hardcoded URL that may need to be updated in the future. Consider extracting it to a configuration file or environment variable.

Suggestion: Move the referral link to a config file (e.g., public/constants.js) or an environment variable to ease future updates.

Risk: If the referral link changes, the banner will point to an invalid or unintended destination until the code is patched.

Confidence: 0.90

[From SubAgent: general]

@jorben jorben merged commit 53e1d43 into master May 13, 2026
4 of 5 checks passed
@jorben jorben deleted the feat/provider-ui-updates branch May 13, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant