perf(cloud): ⚡️ Fix list page repeated refresh when cloud tasks exceed 10

[jorben]

Summary

• Wrap CloudContext.Provider value with useMemo to stabilize context reference across renders
• Narrow fetchTasks dependency from entire cloudContext object to cloudIsAuthenticated + cloudGetTasks
• Replace broken pendingRefresh local variable with useRef + 500ms debounce for SSE-triggered refresh
• Move refresh scheduling out of setState updater (React anti-pattern) into event handler body using dataRef

Test Plan

• With 10+ cloud tasks, verify list page no longer flickers/repeatedly loads
• Verify SSE progress updates still work for tasks already in the list
• Verify new tasks appear after ~500ms debounce window
• Verify page visibility change still triggers single refresh
• Verify polling timer is not repeatedly recreated

🤖 Generated with TiyCode

[github-actions]

AI Code Review Summary

PR: #70 (perf(cloud): ⚡️ Fix list page repeated refresh when cloud tasks exceed 10)
Preferred language: English

Overall Assessment

No blocking issue was detected in the reviewed diff; keep focused regression testing before merge.

Major Findings by Severity

No major issues identified from the reviewed diff.

Actionable Suggestions

• Address the highest severity findings first and add targeted tests for changed logic.

Potential Risks

• Potential hidden risks remain in edge cases not covered by the current diff context.

Test Suggestions

• Add happy-path + boundary + failure-path tests for touched modules.

File-Level Coverage Notes

• src/renderer/contexts/CloudContext.tsx: Optimization by wrapping context value in useMemo. The dependency list includes all state values and callback functions. Ensure any future additions are also added to the list to avoid stale values. No regressions. (The dependency list is long but correct for current code. Maintainability risk if new state/functions are added without updating the list.)
• src/renderer/pages/List.tsx: Refactored SSE event handling with debounced refresh for missing tasks and improved dependency tracking for fetchTasks. The use of refs for data and debounce state prevents stale closures and unnecessary re-renders. Cleanup properly clears timer. Edge case: dataRef may be stale between render and SSE event, but impact is minimal. (The hardcoded 500ms debounce delay could be extracted to a constant for better maintainability.)

Inline Downgraded Items (processed but not inline)

• None

Coverage Status

• Target files: 2
• Covered files: 2
• Uncovered files: 0
• No-patch/binary covered as file-level: 0
• Findings with unknown confidence (N/A): 0

Uncovered list:

• None

No-patch covered list:

• None

Runtime/Budget

• Rounds used: 1/4
• Planned batches: 1
• Executed batches: 1
• Sub-agent runs: 1
• Planner calls: 1
• Reviewer calls: 1
• Model calls: 2/64
• Structured-output summary-only degradation: NO

[github-actions]

Automated PR review completed.

• Findings kept: 0
• Findings with unknown confidence: 0
• Inline comments attempted: 1
• Target files: 2
• Covered files: 2
• Uncovered files: 0
  See the summary comment for detailed analysis and coverage details.

[github-actions]

Automated review completed for this PR diff. No concrete inline issue was selected after aggregation.