Security: Harden Proxy Protocol V2 parsing against OOB reads and shor…#4999
Open
uwezkhan wants to merge 1 commit intoMariaDB:mainfrom
Open
Security: Harden Proxy Protocol V2 parsing against OOB reads and shor…#4999uwezkhan wants to merge 1 commit intoMariaDB:mainfrom
uwezkhan wants to merge 1 commit intoMariaDB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t readsThis improves validation in the PROXY protocol v2 parsing path.
The previous implementation assumed vio_read() would return the full
requested number of bytes, but short reads are possible and could leave
parts of the header buffer only partially initialized while parsing
continued.
This patch updates the parser to read the full fixed and trailing header
sections before processing, corrects trailer length decoding from network
byte order, and validates that enough address data is present for each
supported address family before accessing it.
Malformed or truncated PROXY v2 headers are now rejected safely.