proxy_protocol: fix off-by-one stack buffer overflow in PROXY v1 head…#4998
Open
uwezkhan wants to merge 1 commit intoMariaDB:bb-10.11-midenok-MDEV-25529from
Open
proxy_protocol: fix off-by-one stack buffer overflow in PROXY v1 head…#4998uwezkhan wants to merge 1 commit intoMariaDB:bb-10.11-midenok-MDEV-25529from
uwezkhan wants to merge 1 commit intoMariaDB:bb-10.11-midenok-MDEV-25529from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header parsing loop could append a null terminator past the end of
the buffer when processing maximum-length PROXY v1 headers.
Fix by increasing the buffer size by one byte and using bounded reads
while preserving full header parsing.
Treat zero-length reads as connection close in this context.
Add a regression test for maximum-length PROXY headers.