MDEV-39351: too narrow decimal precision for expression cache#4997
Open
DaveGosselin-MariaDB wants to merge 1 commit into10.11from
Open
MDEV-39351: too narrow decimal precision for expression cache#4997DaveGosselin-MariaDB wants to merge 1 commit into10.11from
DaveGosselin-MariaDB wants to merge 1 commit into10.11from
Conversation
The expression cache had a narrower precision than the decimal value that it cached, leading to a wrong result as truncation errors compounded over the query's lifetime. Fix this by taking the actual precision of the decimal value before initializing the expression cache (rather than the default value found in the Type_numeric_attributes parent class) and using it to initialize the expression cache's temporary table result field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expression cache had a narrower precision than the decimal value that it cached, leading to a wrong result as truncation errors compounded over the query's lifetime. Fix this by taking the actual precision of the decimal value before initializing the expression cache (rather than the default value found in the Type_numeric_attributes parent class) and using it to initialize the expression cache's temporary table result field.