MDEV-38213/MDEV-38213 RocksDB compiler cleanup#4979
Open
grooverdan wants to merge 2 commits intoMariaDB:11.4from
Open
MDEV-38213/MDEV-38213 RocksDB compiler cleanup#4979grooverdan wants to merge 2 commits intoMariaDB:11.4from
grooverdan wants to merge 2 commits intoMariaDB:11.4from
Conversation
…Lists.txt Removed outdated compiler version checks in storage/rocksdb/CMakeLists.txt: - GCC < 4.8 and < 5.0 checks - Clang < 3.3 checks - CMake < 3.0 fallback logic - Manual -std=c++11 flag handling Replaced with modern CMAKE_CXX_STANDARD configuration.
MDEV-38855 removed the C++11 compiler checks from CMakeLists.txt but
left a ${CXX11_FLAGS} reference in the SSE4.2 compile check. Remove
it, as the C++ standard is now inherited from the parent project.
All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon
Web Services, Inc.
grooverdan
added
the
External Contribution
Contributor
|
Not much to additional review here compared to the original PRs; the remaining question is whether we do cleanup in past LTSes at all. |
grooverdan
added
MariaDB Foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take contributions from #4663 and the correction #4974 and backport these to 11.4
As non-impacting changes its good to have these on a branch earlier.
10.6 and 10.11 are still being on RHEL7 but from 11.4+ there isn't the need to rely on unmaintained compilers.