Fix Silo build with MPI-enabled HDF5

[ChrisZYJ]

Description

Fix Silo build failures on systems using MPI-enabled HDF5.
Non-breaking for existing successful builds.

• Bug fix

Testing

Verified build on a system with MPI-enabled HDF5.
Verified build on Frontier (GPU).

AI code reviews

Reviews are not triggered automatically. To request a review, comment on the PR:

• @coderabbitai review — incremental review (new changes only)
• @coderabbitai full review — full review from scratch
• /review — Qodo review
• /improve — Qodo code suggestions
• @claude full review — Claude full review (also triggers on PR open/reopen/ready)
• Add label claude-full-review — Claude full review via label

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 72c21f8b-2c79-4a4e-b4c2-624fad85eb5c

📥 Commits

Reviewing files that changed from the base of the PR and between 00aa603 and aae2863.

📒 Files selected for processing (1)

• toolchain/dependencies/CMakeLists.txt

---

📝 Walkthrough

Walkthrough

The change modifies the CMake build logic for SILO when using ExternalProject_Add instead of find_package. It adds logic to locate an MPI C installation and updates CMAKE_C_FLAGS with MPI C include directories. These flags are then passed to the SILO configuration to ensure MPI headers transitively required by the system's HDF5 MPI variant are discoverable during compilation.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix Silo build with MPI-enabled HDF5' directly and clearly summarizes the main change: fixing build issues when HDF5 has MPI support enabled.
Description check	✅ Passed	The description covers the key sections with problem statement, type (bug fix checkbox marked), and testing verification, though it lacks specific issue reference and detailed testing methodology.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.76%. Comparing base (be1e665) to head (d9f39c8).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1386   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files          71       71           
  Lines       18713    18713           
  Branches     1549     1549           
=======================================
  Hits        12119    12119           
  Misses       5638     5638           
  Partials      956      956           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.