Code audit: fix memory leaks, SQL formatting, and migration bug

[rsharrott]

Summary

Audit pass over the iOS Objective-C codebase (jFlash/Classes/AppSpecific/). This PR contains only the simple, high-confidence fixes. Larger architectural issues are listed below for separate decisions.

Fixes in this PR

Memory leaks

• ActionBarViewController.shareWord — [NSMutableArray new] and the UIActivityViewController were both leaked on every share invocation.
• StudyViewController.dealloc — the retained delegate property was never released. Each instance leaked its delegate (and the comment in the header already flagged the design).
• TweetWordAuthController.dealloc — same: retained delegate never released.

Database

• UserHistoryPeer._recordResult: — replaced +[NSString stringWithFormat:]-built INSERT with a parameterized FMDB query. The old form also wrapped integers in single quotes ('%d'), which stored them with TEXT affinity in SQLite.
• ExampleSentencePeer — converted retrieveExampleSentenceByPK, getExampleSentencesByCardId, sentencesExistForCardId, and searchSentencesForKeyword to parameterized queries via a new retrieveSentencesWithSQL:hydrate:arguments: overload.
• ExampleSentencePeer.retrieveExampleSentenceByPK: now returns nil instead of crashing on -[NSArray objectAtIndex:0] when no row matches the id.

Migrations

• UpdateManager._runMultipleSQLStatements: — the while (!feof(fh)) loop re-executed the previous SQL line whenever the final fgets hit EOF without producing a fresh line (the buffer still held the prior contents). Driven off fgets's return value now.

Test plan

• Build for iOS (jFlash + cFlash targets).
• Manual: search-results path (SearchViewController → CardPeer.searchCardsForKeyword) — try a query that previously broke on ' characters.
• Manual: study mode quiz/practice — record right/wrong answers (exercises UserHistoryPeer).
• Manual: tap an example sentence on a card (exercises ExampleSentencePeer).
• Manual: Share button on a card (exercises ActionBarViewController.shareWord — verify Activity sheet appears and dismisses cleanly under Instruments / Allocations).
• Manual: fresh install on top of an old jFlash.db to exercise the migration runner.

Not in this PR — needs decision

See the audit summary in the conversation for details. Roughly:

1. CardPeer._FTSSQLForKeyword: — the user's search keyword is concatenated into an FTS MATCH query. A query containing ' breaks the SQL today; this should be either parameterized or sanitized via FTS escape rules.
2. Twitter / OAuth removal — TweetWordAuthController and the bundled OAuthConsumer lib are dead code; Twitter v1 OAuth no longer works. Recommend deleting along with LWE_TWITTER_* constants.
3. Delegate retain pattern — StudyViewController and TweetWordAuthController retain their delegates. Per Apple convention these should be assign/weak, but flipping them needs a sweep of callers.
4. Deprecated UIWebView — CardViewController and TweetWordAuthController still use UIWebView (deprecated since iOS 12, removed in iOS 17/18 builds). Migrate to WKWebView (already done in ExampleSentencesViewController).
5. JS string interpolation in WebViews — CardViewController._injectMeaningHTML: only escapes single quotes; backslashes and newlines in card meanings will break the JS. Low risk but fragile.
6. Card.playerWithPluginManager: — returns [_player autorelease] while keeping the ivar. Caller must immediately retain or the ivar dangles. Refactor to a clean ownership model.
7. NSNotificationCenter observer hygiene — most uses are on singletons (no real leak), but the block-based observer in jFlashAppDelegate deserves an audit if anything besides the app delegate ever uses that pattern.
8. ASIHTTPRequest — listed as a submodule; deprecated since 2012. PluginManager uses it. Replace with NSURLSession.

https://claude.ai/code/session_01Gnm7rMhNx8tVssjNzYmvP1

---

Generated by Claude Code