Skip to content

Move Brackets Style#7533

Merged
Eetwalt merged 2 commits into
mainfrom
feature/move-bracket-colors
May 20, 2026
Merged

Move Brackets Style#7533
Eetwalt merged 2 commits into
mainfrom
feature/move-bracket-colors

Conversation

@JuJinPark
Copy link
Copy Markdown
Contributor

Summary

Moving the brackets colors logic from the Lakesideview rep to the Lua-Modules repo.
This is part of the CSS cleanup task, similar to what was done in this PR :#7479

Related MR

https://gitlab.com/teamliquid-dev/liquipedia/web/skins/lakesideview/-/merge_requests/195

How did you test this change?

@JuJinPark JuJinPark self-assigned this May 20, 2026
Copilot AI review requested due to automatic review settings May 20, 2026 05:34
@JuJinPark JuJinPark requested review from a team as code owners May 20, 2026 05:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ports the bracket color custom-properties logic (used by BracketDisplay/MatchlistDisplay/MatchSummary) from the Lakesideview skin into the Lua-Modules shared stylesheet layer, as part of the ongoing CSS cleanup/migration.

Changes:

  • Introduces a $brackets-colors Sass map to centralize bracket color values for light/dark themes.
  • Defines the five --brackets-* CSS custom properties under html.theme--light and html.theme--dark via @each iteration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ElectricalBoy ElectricalBoy added c: match2 stylesheets Changes to stylesheets labels May 20, 2026
Comment thread stylesheets/commons/Brackets.scss Outdated
@Eetwalt Eetwalt merged commit 9d1cf03 into main May 20, 2026
7 checks passed
@Eetwalt Eetwalt deleted the feature/move-bracket-colors branch May 20, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: match2 stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants