Skip to content

feat(PlayerExt): add function to parse standardPlayer from lpdb_player record#7527

Open
hjpalpha wants to merge 3 commits into
mainfrom
fromLpdbPlayerRecord
Open

feat(PlayerExt): add function to parse standardPlayer from lpdb_player record#7527
hjpalpha wants to merge 3 commits into
mainfrom
fromLpdbPlayerRecord

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented May 18, 2026

Summary

we use similar functionality in several modules with this we can replace them all with a call to this

also fixes mock lpdb

How did you test this change?

testcase

@hjpalpha hjpalpha force-pushed the fromLpdbPlayerRecord branch from 44f2cb8 to 543e72e Compare May 18, 2026 07:24
@hjpalpha hjpalpha marked this pull request as ready for review May 18, 2026 07:27
@hjpalpha hjpalpha requested review from a team as code owners May 18, 2026 07:27
ElectricalBoy

This comment was marked as resolved.

@hjpalpha
Copy link
Copy Markdown
Collaborator Author

---@class EnrichedStandardPlayer: standardPlayer
---@field name string?
---@field image string?
---@field birthDate string?
---@field currentTeam string?
---@field links table?
---@field role string?
---@field fromOpponentType OpponentType

imo moving EnrichedStandardPlayer-related stuff to Player/Ext as well would be better for maintainability

imo oos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants