fix(PlayerTournamentAppearances): players with spaces/underscores not counted together correctly

[hjpalpha]

Summary

new team participants store with spaces unless Info.config.forceUnderscores is enabled
old TC did store with underscores on some wikis

this mismatch causes issues in PlayerTournamentAppearances as it doesn't treat e.g. A_Hao_ei and A Hao ei as the same

How did you test this change?

dev

[mbergen]

This seems like we should rather fix the regression in TeamParticipants, no?

[hjpalpha]

This seems like we should rather fix the regression in TeamParticipants, no?

it gest fixed automatically once all tc are migrated

[mbergen]

it gest fixed automatically once all tc are migrated

How so? There's a change in how TPs stores pagenames compared to old TCs, and any other consumer that might depend on it breaks?

[hjpalpha]

it gest fixed automatically once all tc are migrated

How so? There's a change in how TPs stores pagenames compared to old TCs, and any other consumer that might depend on it breaks?

most components catch it already
and with the rollout via legacy wrapper it will be the same everywhere again
(the issue is caused by tournemnts on the same wiki storing it 2 different ways)

[mbergen]

most components catch it already and with the rollout via legacy wrapper it will be the same everywhere again (the issue is caused by tournemnts on the same wiki storing it 2 different ways)

There's still a lot of cases with plain gsub (instead of Module:Page), that might assume that its stored with underscores, which could fail regardless of there being two variants.

It's also a change for API consumers, and generally a step back, given we eventually want to always store pagenames with underscores?

[hjpalpha]

most components catch it already and with the rollout via legacy wrapper it will be the same everywhere again (the issue is caused by tournemnts on the same wiki storing it 2 different ways)

There's still a lot of cases with plain gsub (instead of Module:Page), that might assume that its stored with underscores, which could fail regardless of there being two variants.

It's also a change for API consumers, and generally a step back, given we eventually want to always store pagenames with underscores?

fwiw the new version (TeamParticipants) is at least consistent in that it uses Info.config.forceUnderscores to determine if it should use underscore or not

[mbergen]

fwiw the new version (TeamParticipants) is at least consistent in that it uses Info.config.forceUnderscores to determine if it should use underscore or not

That's great in theory, but bad in practice is what i'm trying to say.
Iirc that flag isn't enabled on a lot of wikis, we should probably try to push on that.