feat: SC2 birthdaylist#7524
Open
hjpalpha wants to merge 2 commits into
Open
Conversation
Collaborator
ElectricalBoy
left a comment
ElectricalBoy
left a comment
There was a problem hiding this comment.
I am fairly convinced that this could (should?) share some code with Module:ThisDay/Query
Collaborator
Author
how so? |
mbergen
approved these changes
May 20, 2026
Collaborator
There was a problem hiding this comment.
Nothing specific for sc2, we can put it on commons i'd say
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as title states
How did you test this change?
dev to live on sc2