refactor: clean up leagueicon implementation#7516
Open
ElectricalBoy wants to merge 13 commits into
Open
Conversation
ElectricalBoy
force-pushed
the
lis-cleanup
branch
2 times, most recently
from
999dcfd to
072ea49
Compare
hjpalpha
reviewed
May 18, 2026
Comment on lines
+123
to
+130
| '[[', | ||
| table.concat(Array.extend( | ||
| 'File:' .. icon, | ||
| 'link=' .. link, | ||
| Logic.emptyOr(name, link), | ||
| size and (size .. 'x' .. size .. 'px') or nil | ||
| ), '|'), | ||
| ']]' |
Collaborator
There was a problem hiding this comment.
why not use icon/image widget?
Collaborator
Author
There was a problem hiding this comment.
because everything has to be slapped with tostring() anyway to avoid existing usages breaking, I didn't bother to import it
either way I don't have a strong opinion
hjpalpha
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How did you test this change?
included test