chore: removed aom and aoe3 non-factions from aoe factions modules.#7498
Open
Libavi wants to merge 8 commits into
Open
chore: removed aom and aoe3 non-factions from aoe factions modules.#7498Libavi wants to merge 8 commits into
Libavi wants to merge 8 commits into
Conversation
In AoM, the civs are no factions, gods are. The civs are comparable to AoE2 architecture sets or aoe4 classical civilizations.
Contributor
Author
|
Failing checks is a bug: #7496 |
Libavi
changed the title
Collaborator
|
I don't really mind them being there tbh, although it looks like we don't have any usage right now. |
ElectricalBoy
added
g: ageofempires
Contributor
Author
yeah, it's definetely not urgent. I just dislike unused code everywhere I see it. And here, I don't see a reason it will or should ever be used. Additionally, these affect the civ counter on the main page. |
Collaborator
No, that is a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Age of Mythology, civilizations are no factions, just a group of factions comparable to architecture sets in AoE2 or classical civilizations in AoE4. You can pick a civilization for a match, but you will just get a randomly picked god within this civ.
The modules are used for match info. It never makes sense to put a civ in aom as faction for a game instead of a god. This should not be possible.