feat: use custom html builder for widget3#7467
Conversation
637c48e to
0abfab5
Compare
There was a problem hiding this comment.
Pull request overview
This PR changes the Widget3 renderer to build HTML output via a custom string builder instead of relying on mw.html, likely aiming to reduce overhead during render.
Changes:
- Added a custom HTML string builder (
buildHtmlString) including a void/self-closing tag list and attribute escaping. - Updated
Renderer.renderfor HTML-tag VNodes to render children and emit HTML via the new builder (with special handling forfragment).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ElectricalBoy
left a comment
There was a problem hiding this comment.
how does this compare to mw.html lib performance wise?
It's on my TODO To test, you can test if you want. It should perform better in memory management I expect |
|
test: https://liquipedia.net/leagueoflegends/Module:Sandbox/ElectricalBoy/widget3-perf
|
|
|
reg perf test: did you create the dev for the live comparison? |
yes |
Summary
TODO: Test performance
How did you test this change?