Skip to content

feat(Infobox) : Delta Force Infobox league (wip)#7442

Open
Hesketh2 wants to merge 7 commits into
mainfrom
H2-DF-League2
Open

feat(Infobox) : Delta Force Infobox league (wip)#7442
Hesketh2 wants to merge 7 commits into
mainfrom
H2-DF-League2

Conversation

@Hesketh2
Copy link
Copy Markdown
Collaborator

@Hesketh2 Hesketh2 commented Apr 29, 2026

Summary

Delta Force is planned for next export in May

this new PR is a re-open of #7276 because those snapshot appearing I think it might have break PR (or require rebase?) so I close and re-open a new one, and I try to fix or update it again (much as I can with my limited coding knowledge)

DF's InfoLeague needs are: Modes Platforms and Patch

What I did in this version here is mostly patching how these three are done in other wikis together and maybe adjust it a bit. So will still need help here (maybe this is one is cleaner vs the previous)

Test

https://liquipedia.net/lab/Deltaforce/Pan-Pacific_Warfare_Cup/2026
Test modules will be removed from Lab post-export

@Hesketh2 Hesketh2 self-assigned this Apr 29, 2026
@Hesketh2 Hesketh2 marked this pull request as ready for review May 17, 2026 15:44
@Hesketh2 Hesketh2 requested review from a team as code owners May 17, 2026 15:44
@Hesketh2
Copy link
Copy Markdown
Collaborator Author

Export has been ticketed, so I should mark this as green ahead.

Comment on lines +64 to +76
if String.isNotEmpty(args.map1) then
local game = String.isNotEmpty(args.game) and ('/' .. args.game) or ''
local maps = {}

for _, map in ipairs(self.caller:getAllArgsForBase(args, 'map')) do
table.insert(maps, tostring(self.caller:_createNoWrappingSpan(
Page.makeInternalLink({}, map, map .. game)
)))
end
table.sort(maps)
table.insert(widgets, Title{children = 'Maps'})
table.insert(widgets, Center{children = {table.concat(maps, ' • ')}})
end
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if String.isNotEmpty(args.map1) then
local game = String.isNotEmpty(args.game) and ('/' .. args.game) or ''
local maps = {}
for _, map in ipairs(self.caller:getAllArgsForBase(args, 'map')) do
table.insert(maps, tostring(self.caller:_createNoWrappingSpan(
Page.makeInternalLink({}, map, map .. game)
)))
end
table.sort(maps)
table.insert(widgets, Title{children = 'Maps'})
table.insert(widgets, Center{children = {table.concat(maps, ' • ')}})
end
if Logic.isEmpty(args.map1) then return end
local gameSuffix = Logic.isNotEmpty(args.game) and ('/' .. args.game) or ''
local maps = self.caller:getAllArgsForBase(args, 'map')
table.sort(maps)
local mapDisplays = Array.map(maps, function(map)
return Link{link = map .. gameSuffix, children = map}
end)
Array.appendWith(cells,
Title{children = 'Maps'},
Center{children = Array.interleave(mapDisplays, ' • ')}
)

Copy link
Copy Markdown
Collaborator Author

@Hesketh2 Hesketh2 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into attempt to call global 'Link' (a nil value). on other reviews, What Module I should called for Link?

image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Widget/Basic/Link

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I have fixed that, I ran into two more errors atm

one is when I input any into |map1= Module:Array at line 430: bad argument #1 to 'insert' (table expected, got nil). , the second is the single lint fail checks about cells, after I try replace that with Cell the input no longer works/displayed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cells —> widgets
my bad

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what i do wrong here, I still get these errors ( Can be tested at https://liquipedia.net/lab/Deltaforce/Delta_Force_Global_League/Season_2/Asia/Operations )

image

Here's what I tried
image

image image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of which make no sense at all ...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if String.isNotEmpty(args.map1) then
local game = String.isNotEmpty(args.game) and ('/' .. args.game) or ''
local maps = {}
for _, map in ipairs(self.caller:getAllArgsForBase(args, 'map')) do
table.insert(maps, tostring(self.caller:_createNoWrappingSpan(
Page.makeInternalLink({}, map, map .. game)
)))
end
table.sort(maps)
table.insert(widgets, Title{children = 'Maps'})
table.insert(widgets, Center{children = {table.concat(maps, ' • ')}})
end
if Logic.isEmpty(args.map1) then return end
local gameSuffix = Logic.isNotEmpty(args.game) and ('/' .. args.game) or ''
local maps = self.caller:getAllArgsForBase(args, 'map')
table.sort(maps)
local mapDisplays = Array.map(maps, function(map)
return Link{link = map .. gameSuffix, children = map}
end)
Array.appendWith(widgets,
Title{children = 'Maps'},
Center{children = Array.interleave(mapDisplays, ' • ')}
)

Comment thread lua/wikis/deltaforce/Infobox/League/Custom.lua Outdated
Comment thread lua/wikis/deltaforce/Infobox/League/Custom.lua Outdated
Comment thread lua/wikis/deltaforce/Infobox/League/Custom.lua Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants