Skip to content

Review docker examples#202

Merged
colisee merged 7 commits intoLibreBooking:masterfrom
colisee:ex_docker
May 5, 2026
Merged

Review docker examples#202
colisee merged 7 commits intoLibreBooking:masterfrom
colisee:ex_docker

Conversation

@colisee
Copy link
Copy Markdown
Collaborator

@colisee colisee commented May 5, 2026

No description provided.

@colisee colisee requested a review from ikke-t May 5, 2026 15:06
@colisee colisee added the documentation Improvements or additions to documentation label May 5, 2026
@ikke-t
Copy link
Copy Markdown
Collaborator

ikke-t commented May 5, 2026

Minor thing for perhaps some future update if not here. The image and resource upload dirs is good to have like you added. Better yet if they were added also to Dockerfile as Volumes.

Anyhow, looks good to me as visual overview.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not try this, but the config volume removal caught my eye. Does cron really work without config being there?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I should have opened the full file, it gets it from app

@colisee
Copy link
Copy Markdown
Collaborator Author

colisee commented May 5, 2026

Minor thing for perhaps some future update if not here. The image and resource upload dirs is good to have like you added. Better yet if they were added also to Dockerfile as Volumes.

Anyhow, looks good to me as visual overview.

This is something to keep in mind. I’d like upstream to settle the issue of the favicon and to define 1 directory for all uploads.

@colisee colisee merged commit c96496a into LibreBooking:master May 5, 2026
3 checks passed
@colisee colisee deleted the ex_docker branch May 5, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants