fix(ci): add version comments to SHA-pinned GitHub Actions#154
Open
anupsv wants to merge 1 commit into
Open
Conversation
All workflow actions were already correctly SHA-pinned, but pnpm/action-setup and actions/setup-node were missing the version comment that makes the pinned SHA auditable at a glance. - pnpm/action-setup@fc06bc1... → # v4.4.0 - actions/setup-node@49933ea... → # v4.4.0 - actions/checkout@11bd719... → # v4.2.2 (already present) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
anupsv
requested review from
Chris-Moller,
solimander,
taekyunggg and
vineetguptadev
as code owners
mcclurejt
added a commit
that referenced
this pull request
May 15, 2026
The platform now sets tee-env-ECLOUD_PLATFORM_HOST directly from cfg.DeriveAppHostname(appAddress) at VM-create time (see ecloud-platform PR #154). Injecting it into publicEnv from the client made the user's on-chain release blob carry a value the user never supplied — visible in 'ecloud compute app info' and the verify dashboard, and frozen in the release record so a later AppBaseDomain change can't update it. Platform-derived values belong in platform metadata. Drop the injection. derivePlatformHost stays exported because external consumers (e.g. scripts/e2e/lib/cli.sh's mirror in the ecloud-platform harness) still use it for client-side hostname derivation when they need to predict the platform's choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm/action-setupandactions/setup-nodewere missing the version comment that makes pinned SHAs human-readable and auditableSHA Verification
actions/checkout11bd71901bbe5b1630ceea73d27597364c9af683pnpm/action-setupfc06bc1257f339d1d5d8b3a19a8cae5388b55320actions/setup-node49933ea5288caeca8642d1e84afbd3f7d6820020All SHAs verified via GitHub API against their respective release tags.
Test plan
🤖 Generated with Claude Code