Update tests that relied on obsolete actions.#3001
Open
labkey-klum wants to merge 1 commit into
Open
Conversation
labkey-tchad
approved these changes
May 16, 2026
Comment on lines
+1691
to
+1699
| drt.clickInsertNewRow(); | ||
| waitForElement(Locator.name("quf_Schema")); | ||
| setFormElement(Locator.name("quf_Schema"), schema); | ||
| setFormElement(Locator.name("quf_QueryName"), query); | ||
| if (viewName != null) | ||
| setFormElement(Locator.name("ff_viewName"), viewName); | ||
| clickButton("Create"); | ||
| StringBuilder strFields = new StringBuilder(fields[0]); | ||
| for (int i = 1; i < fields.length; i ++) | ||
| { | ||
| strFields.append("&"); | ||
| strFields.append(fields[i]); | ||
| } | ||
| setFormElement(Locator.name("ff_columnList"), strFields.toString()); | ||
| clickButton("Save"); | ||
| setFormElement(Locator.name("quf_Name"), viewName); | ||
| setFormElement(Locator.name("quf_Columns"), String.join("&", fields)); | ||
| setFormElement(Locator.name("quf_Flags"), "0"); | ||
| clickButton("Submit"); |
Member
There was a problem hiding this comment.
Use the page class returned by clickInsertNewRow instead of hard-coded locators.
| getProjectName() + "/" + VISIT_STUDY_FOLDER_NAME + "/" + publishFolderName, | ||
| "reportInfo", Map.of("reportId", getUrlParam("reportId")))); | ||
| waitForText("Report Debug Information"); | ||
| } |
Member
There was a problem hiding this comment.
The for-loop above (over VISIT_CHARTS) no longer does anything interesting. Might as well remove it.
Comment on lines
+327
to
+328
| drt = new DataRegionTable("query", getDriver()); | ||
| int xmlIdx = drt.getColumnIndex("DescriptorXML"); |
Member
There was a problem hiding this comment.
Not sure how many reports get created by this test but you might want to increase the grid size to make sure nothing is hiding on later pages.
Suggested change
| drt = new DataRegionTable("query", getDriver()); | |
| int xmlIdx = drt.getColumnIndex("DescriptorXML"); | |
| drt = new DataRegionTable("query", getDriver()); | |
| drt.setPageSize(100); | |
| int xmlIdx = drt.getColumnIndex("DescriptorXML"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
A recent PR removed some internal actions like
query.internalNewViewandreports.reportInfo. I've updated those tests to rely on alternate ways to accomplish the same actions.