feat : import support both app and VIA format#26
Open
AayushM0 wants to merge 4 commits into
Open
Conversation
|
@AayushM0 is attempting to deploy a commit to the Ava Consult Team on Vercel. A member of the Team first needs to authorize it. |
karava
approved these changes
Mar 25, 2026
karava
left a comment
There was a problem hiding this comment.
Looks good! Clean separation of import/export logic, and the VIA format support is solid.
One small typo to fix:
- In
page.tsx, the KeyLab export filename is"kyelab-keymap.json"— should be"keylab-keymap.json"
(Or "zumap-keymap.json" if we're going with the new name 😄)
Otherwise, ready to merge. Nice work @AayushM0! 🎉
Author
|
Hello i have fixed the typo and the final PR should be good to go now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds full support for importing and exporting VIA-compatible keymap JSON files.
This enables interoperability with the VIA ecosystem while preserving compatibility with KeyLab’s internal keymap format.
Problem
Previously, the application only supported its internal keymap format:
{ "name": "...", "keyboard": "...", "layers": [...] }This made it incompatible with VIA keymaps, which use:
{ "version": 1, "layers": [...] }Solution
Import
{ version, layers }{ name, keyboard, layers }Export
{ "version": 1, "layers": [...] }{ "name": "...", "keyboard": "...", "layers": [...] }UI Changes
Behavior
Import
Export
Design Notes
Related to issue #4
Updates
page.tsxtokeymap.tsimportAnyKeymapimportKeymapAdding images for reference
on importing
data = {
"version": 1,
"layers": [
[
"KC_Q","KC_W","KC_E","KC_R","KC_T",
"KC_Y","KC_U","KC_I","KC_O","KC_P",
"KC_A","KC_S","KC_D","KC_F","KC_G"
]
]
}
we get
Final UI
Export VIA - highlighted