Feat/ca cleanup enrollment fields#32
Merged
spbsoluble merged 8 commits intomainfrom Apr 30, 2026
Merged
Conversation
… config Commit 2b88eb2 (2026-03-18) accidentally stripped AccessToken, Audience, and Scopes from the CommandConfigOauth struct literal in buildHttpClientV2 in both v1/client.go and v2/client.go. This broke pre-fetched access_token authentication mode where users supply only hostname + access_token without client_id/client_secret/token_url. Restore all three fields so the auth client receives the caller-provided token, audience, and scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UseForEnrollment,ForceSave, and certificate cleanup fields (AllowedEnrollmentTypes,StandaloneCA,MonitorThresholds, etc.) to CA request/response models inv24/api/keyfactor/v1AccessToken,Audience,Scopesfields tobuildHttpClientV2OAuth config (broken in prior refactor)release-v24.0; sync CHANGELOGaccess_tokenregression tests for v2 client (v24 + v25)model_certificate_authorities_test.go) for v24/v25Motivation
The provider (
terraform-provider-keyfactor) requires these CA model fields for the CA resource create/update/delete lifecycle — specificallyForceSaveto bypass connectivity validation,AllowedEnrollmentTypesfor standalone CAs, and scan schedule fields whose presence blocks CA deletion on DCOM labs. The OAuth fix is required for labs usingaccess_tokenauth.These changes have been validated against the ses2541 lab (EJBCA/OAuth) via the provider's integration test suite running on
v24.1.1-rc.3.Test plan
go test ./...inv24/andv25/access_token,audience,scopesround-trip