Refactor verifyproblem - extract Diagnostics #398#409
Merged
pehrsoderman merged 2 commits intoKattis:masterfrom Apr 22, 2026
Merged
Refactor verifyproblem - extract Diagnostics #398#409pehrsoderman merged 2 commits intoKattis:masterfrom
pehrsoderman merged 2 commits intoKattis:masterfrom
Conversation
pehrsoderman
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting to break apart verifyproblem, #398. These PR:s are going to quickly end up on the large side, unfortunately.
This PR cleans up the interface to Problem a bit by doing two things:
Diagnosticswhich a called toProblemsupplies and which handles logging and error counting. This got rid of most of the reasons forProblemtaking anargparse.NamespaceargumentContext, and let the caller supply that when callingproblem.check()The
Diagnosticsobjects are currently stored inProblemAspect, to keep the size of this PR a bit more manageable.