Skip to content

Enhance error handling in FactorDFG and VariableDFG constructors#1238

Merged
Affie merged 2 commits into
developfrom
enh/addVarFac
May 19, 2026
Merged

Enhance error handling in FactorDFG and VariableDFG constructors#1238
Affie merged 2 commits into
developfrom
enh/addVarFac

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented May 19, 2026

Ensure unique variable orders and proper tag initialization

Affie added 2 commits May 19, 2026 10:31
…ure unique variable orders and proper tag initialization
@Affie Affie self-assigned this May 19, 2026
@Affie Affie added the API label May 19, 2026
@Affie Affie added this to the v0.29.1 milestone May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.82%. Comparing base (7448d2e) to head (aed72dd).

Files with missing lines Patch % Lines
src/entities/Factor.jl 60.00% 2 Missing ⚠️
src/services/compare.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1238      +/-   ##
===========================================
- Coverage    80.87%   80.82%   -0.06%     
===========================================
  Files           50       50              
  Lines         2667     2675       +8     
===========================================
+ Hits          2157     2162       +5     
- Misses         510      513       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Affie Affie merged commit cb9f5d7 into develop May 19, 2026
4 of 6 checks passed
@Affie Affie deleted the enh/addVarFac branch May 19, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant