Fix for has_one relationships where related record does not exist#987
Open
lgebhardt wants to merge 1 commit intoJSONAPI-Resources:release-0-9from
Open
Fix for has_one relationships where related record does not exist#987lgebhardt wants to merge 1 commit intoJSONAPI-Resources:release-0-9from
lgebhardt wants to merge 1 commit intoJSONAPI-Resources:release-0-9from
Conversation
Contributor
|
Looks good to me @lgebhardt, did you want me to try it on my spike branch and see if it fixes my issue? |
Contributor
Author
|
@joegaudet If you could test it that would be appreciated. There was a definite issue when the new tests were added so I'm optimistic it will fix your issue, but knowing for sure would be best. |
Contributor
|
@lgebhardt seems I'm still seeing the same stack trace: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.