Skip to content

Improved error messages for invalid field and invalid type errors #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaggederest wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improved error messages for invalid field and invalid type errors #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
329b2ea
Improved error messages for invalid field and invalid type errors
jaggederest Oct 23, 2016
e9a7263
Include error message changes in i18n file
jaggederest Oct 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/jsonapi/exceptions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def errors
title: I18n.translate('jsonapi-resources.exceptions.type_mismatch.title',
default: 'Type Mismatch'),
detail: I18n.translate('jsonapi-resources.exceptions.type_mismatch.detail',
default: "#{type} is not a valid type for this operation.", type: type))]
default: "#{type} is not a valid type for this operation. Consider checking the spelling or pluralization of the type field.", type: type))]
end
end

Expand All @@ -261,7 +261,7 @@ def errors
title: I18n.translate('jsonapi-resources.exceptions.invalid_field.title',
default: 'Invalid field'),
detail: I18n.translate('jsonapi-resources.exceptions.invalid_field.detail',
default: "#{field} is not a valid field for #{type}.",
default: "#{field} is not a valid field for #{type}. Consider checking the spelling of the field name.",
field: field, type: type))]
end
end
Expand Down
4 changes: 2 additions & 2 deletions locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ en:
detail: 'Data is not a valid Links Object.'
type_mismatch:
title: 'Type Mismatch'
detail: "%{type} is not a valid type for this operation."
detail: "%{type} is not a valid type for this operation. Consider checking the spelling or pluralization of the type field."
invalid_field:
title: 'Invalid field'
detail: "%{field} is not a valid field for %{type}."
detail: "%{field} is not a valid field for %{type}. Consider checking the spelling of the field name."
invalid_include:
title: 'Invalid field'
detail: "%{relationship} is not a valid relationship of %{resource}"
Expand Down