fix resource identifier objects#637
Open
acid wants to merge 2 commits intoJSONAPI-Resources:masterfrom
Open
Conversation
| type: unformat_key(raw['type']).to_s, | ||
| id: raw['id'] | ||
| id: raw['id'], | ||
| meta: raw['meta'] |
Contributor
There was a problem hiding this comment.
This does add a (possibly nil) meta attribute to each resource identifier object, right?
Maybe the following would make more sense:
hash = {
type: unformat_key(raw['type']).to_s,
id: raw['id']
}
hash[:meta] = raw[:meta] if raw.key?(:meta)
hash
Contributor
Author
There was a problem hiding this comment.
I like that, thanks! :)
acid
force-pushed
the
fix_resource_identifier_objects
branch
3 times, most recently
from
2386c29 to
b4f9fb9
Compare
Contributor
|
@acid Looks like the meta will get dropped in |
According to http://jsonapi.org/format/#document-resource-identifier-objects rescource identifier objects can contain an additional meta attribute. This fix adds supports for the full specification.
acid
force-pushed
the
fix_resource_identifier_objects
branch
from
b4f9fb9 to
da9783f
Compare
acid
force-pushed
the
fix_resource_identifier_objects
branch
from
da9783f to
7ce6c3e
Compare
Contributor
Author
|
@lgebhardt you're right. Fixed it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to
http://jsonapi.org/format/#document-resource-identifier-objects
rescource identifier objects can contain an additional meta attribute.
This fix adds supports for the full specification.