Skip to content

Added test and potential fix for #628. #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theirishpenguin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added test and potential fix for #628. #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/jsonapi/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,12 @@ def is_filter_relationship?(filter)

def verify_filter(filter, raw, context = nil)
filter_values = []
filter_values += CSV.parse_line(raw) unless raw.nil? || raw.empty?

begin
filter_values += CSV.parse_line(raw) unless raw.nil? || raw.empty?
rescue CSV::MalformedCSVError => ex
filter_values << raw
end

strategy = _allowed_filters.fetch(filter, Hash.new)[:verify]

Expand Down
9 changes: 9 additions & 0 deletions test/integration/requests/request_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ def test_get_underscored_key
JSONAPI.configuration = original_config
end

def test_filter_with_value_containing_double_quote
original_config = JSONAPI.configuration.dup
JSONAPI.configuration.json_key_format = :underscored_key
get '/iso_currencies?filter[country_name]="'
assert_jsonapi_response 200
ensure
JSONAPI.configuration = original_config
end

def test_get_underscored_key_filtered
original_config = JSONAPI.configuration.dup
JSONAPI.configuration.json_key_format = :underscored_key
Expand Down