Move build system to `meson-python` by ndgrigorian · Pull Request #174 · IntelPython/mkl-service

ndgrigorian · 2026-04-08T02:34:35Z

This PR proposes moving from setuptools to meson-python as the mkl-service build system

meson-python is already used by NumPy and allows setup.py to be removed (with its logic moved into the meson.build script)

Also adds mkl as a dependency

Copilot

Pull request overview

This PR migrates mkl-service from a setuptools/setup.py-driven build to a meson-python build, updating conda recipes and CI workflows accordingly, and adding an mkl runtime dependency.

Changes:

Remove setup.py and define extension builds/install layout in meson.build (C + Cython extensions, Python sources, tests).
Switch pyproject.toml build backend to mesonpy and add mkl to runtime dependencies.
Update conda recipes and GitHub Actions workflows to build/install via pip/python -m build instead of setup.py.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
setup.py	Removed legacy setuptools build script.
pyproject.toml	Switched build backend to `mesonpy`, updated build requirements and runtime deps.
meson.build	Added Meson build definition for C/Cython extensions and installation layout.
mkl/_py_mkl_service.pyx	Added/introduced Cython wrapper implementation used by the public API.
conda-recipe/meta.yaml	Updated conda build requirements for Meson-based builds.
conda-recipe/build.sh	Updated wheel build/install flow (no `setup.py`).
conda-recipe/bld.bat	Removed `setup.py` clean step and MKLROOT usage.
conda-recipe-cf/meta.yaml	Updated conda-forge recipe host requirements for Meson-based builds.
conda-recipe-cf/build.sh	Switched to `pip install .` build/install flow.
conda-recipe-cf/bld.bat	Switched to `pip install .` build/install flow.
.github/workflows/build-with-standard-clang.yml	New CI job building with system clang.
.github/workflows/build-with-clang.yml	Updated IntelLLVM clang CI job to Meson-based install.
.github/workflows/build_pip.yml	New CI job testing editable install + (pre-)release NumPy in conda env.

Copilot · 2026-04-08T18:25:53Z

+    'mkl-service',
+    ['c', 'cython'],
+    version: run_command(
+        'python', '-c',


run_command('python', ...) hardcodes the interpreter, which may not match Meson’s discovered Python (virtualenv/pyenv/Windows). Use the py installation found by import('python').find_installation() when computing the version to avoid mismatched interpreters.

Suggested change

'python', '-c',

import('python').find_installation(pure: false), '-c',

Copilot · 2026-04-08T18:25:54Z

+    strategy:
+      matrix:
+        python: ["3.10", "3.11", "3.12", "3.13", "3.14"]
+        numpy_version: ["numpy'>=2'"]


The matrix value numpy_version: ["numpy'>=2'"] includes embedded quotes and will be passed verbatim to pip install, which is not a valid requirement specifier. Use something like numpy>=2 (or just install numpy and control pre-releases separately).

Suggested change

numpy_version: ["numpy'>=2'"]

numpy_version: ["numpy>=2"]

Copilot · 2026-04-08T18:25:54Z

    strategy:
      matrix:
        python: ["3.10", "3.11", "3.12", "3.13"]
+        numpy_version: ["numpy'>=2'"]


The matrix value numpy_version: ["numpy'>=2'"] includes embedded quotes and will be passed verbatim to pip install, which is not a valid requirement specifier. Use something like numpy>=2.

Suggested change

numpy_version: ["numpy'>=2'"]

numpy_version: ["numpy>=2"]

antonwolfy · 2026-04-24T09:31:32Z

@@ -0,0 +1,70 @@
+project(


Might it be helpful to add meson.options?

It could, but I'm not sure if there's reason to add an empty one

I added an option in PR on top of this one
#184

Maybe I will think of others

antonwolfy · 2026-04-24T09:33:06Z

I guess we need to update AGENTS.md and copilot-instructions.md with that change

And also to reflect there the new build command

antonwolfy · 2026-04-24T09:37:23Z

@@ -0,0 +1,70 @@
+project(


Do we need to add a section to the README.md or similar with the build instructions, when building from the source?

We should revise the build instructions but, in theory, python -m pip install . should still work

antonwolfy · 2026-04-24T09:45:03Z

      - mkl-devel
      - cython
      - wheel >=0.45.1
-      - python-build >=1.2.2


Still used in conda-recipe/meta.yaml. Is that intended?

yes, it's used there because the build script there is more complicated and calls build command

conda-recipe-cf/build.sh just calls python -m pip install . --no-deps --no-build-isolation

antonwolfy · 2026-04-24T09:46:36Z

      - {{ compiler('c') }}
      - {{ stdlib('c') }}
    host:
+      - meson-python >=0.13.0


Would it make sense to parse pyproject.toml and to include the deps from there, as we currently do in dpnp/dpctl?

yes, it probably does, though, I think it would be good for a follow up PR

antonwolfy · 2026-04-24T09:50:07Z

+)
+
+rpath = ''
+if host_machine.system() != 'windows'


Would it be better to be more explicit here? (since that will not work on macOS as well and probably others)

Suggested change

if host_machine.system() != 'windows'

if host_machine.system() == 'linux'

yeah that's a good idea

ndgrigorian requested review from antonwolfy, jharlow-intel and xaleryb as code owners April 8, 2026 02:34

ndgrigorian marked this pull request as draft April 8, 2026 03:59

ndgrigorian force-pushed the use-meson-build branch 4 times, most recently from 1f7006a to e209e46 Compare April 8, 2026 06:35

ndgrigorian marked this pull request as ready for review April 8, 2026 06:51

Base automatically changed from drop-removed-cbwr-constants to master April 8, 2026 17:17

Copilot AI review requested due to automatic review settings April 8, 2026 18:20

ndgrigorian force-pushed the use-meson-build branch from e209e46 to dfc8f4c Compare April 8, 2026 18:20

Copilot started reviewing on behalf of ndgrigorian April 8, 2026 18:21 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

ndgrigorian force-pushed the use-meson-build branch 2 times, most recently from 4a2979d to b3cd7c9 Compare April 10, 2026 00:33

ndgrigorian added 9 commits April 10, 2026 20:05

Use meson as build system

523692e

remove MKLROOT

8f2a4db

add standard clang workflow and update clang workflow

06fb456

add ninja to build-system

c7dba16

use cmake to find MKL and update dependencies

293d9f4

update meta.yamls and conda-forge conda recipes

51d4c87

install mkl-devel when building with standard clang

de88929

add pip build workflow

c311b0f

update conda-recipe build scripts

3fb7aff

ndgrigorian force-pushed the use-meson-build branch from b3cd7c9 to 3fb7aff Compare April 11, 2026 03:05

Merge branch 'master' into use-meson-build

8533094

antonwolfy reviewed Apr 24, 2026

View reviewed changes

	'python', '-c',
	import('python').find_installation(pure: false), '-c',

	if host_machine.system() != 'windows'
	if host_machine.system() == 'linux'

Conversation

ndgrigorian commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ndgrigorian Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ndgrigorian commented Apr 8, 2026 •

edited

Loading

ndgrigorian Apr 24, 2026 •

edited

Loading