Merged
Conversation
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
the __dealloc__ method was missing trailing underscores, so would not be recognized as the deallocator by Cython
ndgrigorian
force-pushed
the
fix-memory-leak-in-rawkernelarg
branch
from
0eb34a7 to
9196807
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
coverage: 77.285% (+0.02%) from 77.262% — fix-memory-leak-in-rawkernelarg into master |
vlad-perevezentsev
approved these changes
Apr 24, 2026
Collaborator
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Great catch!
LGTM
Thank you @ndgrigorian
ndgrigorian
added a commit
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__dealloc__method was written as__dealloc, so would not be recognized as the deallocator by Cython, meaning it has been leaking memory from C