Conversation
- win32 keyboard/mouse listeners + Windows clipboard: mark the four S5655 ctypes byref/sizeof/addressof calls with NOSONAR. Sonar's type checker doesn't know Array and Structure satisfy the _CData contract, so these keep firing as false positives. - test_rest_server: drop the ``:`` between NOSONAR and the rule code so Sonar's Python parser recognises the suppression syntax (S7632) - test_plugin_loader: add NOSONAR next to the existing noqa for the plugin-contract AC_value field and AC_run method (S116 / S100) - test_watcher: replace the ``(_ for _ in ()).throw(...)`` generator trick with a real helper function so S7500 stops flagging the "comprehension passed to collection constructor" pattern; behaviour unchanged (raises OSError when get_pixel is called)
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single-commit follow-up. Closes the last 8 Sonar issues reporting OPEN/CONFIRMED on
main.# NOSONARonctypes.sizeof/addressof/byrefcalls where Sonar's type checker can't proveArray/Structuresatisfy the_CDatacontract. (clipboard.py:96,103;win32_keyboard_listener.py:93;win32_mouse_listener.py:102)test_rest_server.py:19(Sonar-Python expects# NOSONAR <free text>, no colon).# NOSONAR AC_* is the plugin contractnext to the existing noqa forAC_value/AC_runintest_plugin_loader.py.(_ for _ in ()).throw(OSError(...))generator trick intest_watcher.pywith a plaindef _raise_os_errorhelper.Test plan
python -m pytest test/unit_test/headless test/unit_test/flow_control— 139 passed locallypython -m ruff check je_auto_control/ test/— clean