BUG: Remove 7 orphaned tags and disable 12 dependent tests#168
Merged
hjmjohnson merged 2 commits intoInsightSoftwareConsortium:mainfrom Apr 29, 2026
Merged
Conversation
Six .md5 tag files point to MD5 hashes that 404 on gh-pages, Girder,
and itk.org. None of them are referenced by an active test.
Baselines (4): itkFrequencyExpand{Even,Odd}Test.tiff.md5 and
itkFrequencyShrink{Even,Odd}Test.tiff.md5. Their --compare references
in test/CMakeLists.txt are already commented out.
Inputs (2): checkershadow_gray_540x420.jpg.md5 and
checkershadow_gray_540x420.tiff.md5. Neither is referenced anywhere
in test/CMakeLists.txt.
A 7th orphan tag remains in this module
(test/Input/checkershadow_Lch_512x512.tiff.md5) which 10 active
tests depend on; disabling those tests would gut a large portion
of the test suite, so it is left for separate discussion.
The input image checkershadow_Lch_512x512.tiff.md5 points to an MD5
hash that 404s on gh-pages, Girder, and itk.org. Twelve active
test blocks reference DATA{Input/checkershadow_Lch_512x512.tiff}:
itkWaveletFrequencyFilterBankGeneratorTest2D{1,2}
itkWaveletFrequencyFilterBankGeneratorDownsampleTest2D
itkWaveletFrequencyForwardTest2D
itkWaveletFrequencyInverseTest2D
itkWaveletFrequencyInverseTest2DMultiLevelMultiBand
itkStructureTensorWithGeneralizedRieszTest2D
itkRieszWaveletPhaseAnalysisTest2D
itkRieszWaveletPhaseAnalysisTest2DMultiLevelMultiBand
itkFrequencyExpandAndShrinkTest2D
itkFrequencyShrinkEvenTest2D
itkZeroDCImageFilterTest
Comment out each test block with a leading
# DISABLED: checkershadow_Lch_512x512.tiff is orphaned ...
# TODO: re-enable when a replacement baseline is added to ITKTestingData.
header, and remove the dead .md5 tag. The disabled tests can be
restored as soon as a substitute input image is published to the
gh-pages mirror.
hjmjohnson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove orphaned
.md5tag files (blobs 404 from gh-pages / Girder / itk.org) and disable the tests that depend on them.Now includes wholesale disable of 12 tests requiring
checkershadow_Lch_512x512.tiff(the previously-flagged 7th orphan). Each disabled block is prefixed with a# DISABLED ... # TODO: re-enable when a replacement baseline is added to ITKTestingData.header.Removed tags (7 total)
Unused (no test references):
test/Baseline/itkFrequency{Expand,Shrink}{Even,Odd}Test.tiff.md5(4 baselines)test/Input/checkershadow_gray_540x420.{jpg,tiff}.md5(2 inputs)Used by tests now disabled:
test/Input/checkershadow_Lch_512x512.tiff.md5(1 input → 12 tests disabled)Disabled tests (12, all requiring checkershadow_Lch)
itkWaveletFrequencyFilterBankGeneratorTest2D{1,2},itkWaveletFrequencyFilterBankGeneratorDownsampleTest2D,itkWaveletFrequencyForwardTest2D,itkWaveletFrequencyInverseTest2D,itkWaveletFrequencyInverseTest2DMultiLevelMultiBand,itkStructureTensorWithGeneralizedRieszTest2D,itkRieszWaveletPhaseAnalysisTest2D,itkRieszWaveletPhaseAnalysisTest2DMultiLevelMultiBand,itkFrequencyExpandAndShrinkTest2D,itkFrequencyShrinkEvenTest2D,itkZeroDCImageFilterTest.To restore: publish a replacement test image to
ITKTestingData/gh-pages(any 512×512 RGB TIFF will work), add an.cidtag for it, and uncomment the test blocks.