[FIX] update for the bool AnimIsOver that was never passing to false#50
Open
PierreFonda3D wants to merge 1 commit intomainfrom
Open
[FIX] update for the bool AnimIsOver that was never passing to false#50PierreFonda3D wants to merge 1 commit intomainfrom
PierreFonda3D wants to merge 1 commit intomainfrom
Conversation
epernod
reviewed
Apr 28, 2026
Contributor
epernod
left a comment
epernod
left a comment
There was a problem hiding this comment.
same this PR is flagged as wip but seem to be ready for review no?
Comment on lines
+262
to
+265
| private IEnumerator SmoothTransitionPosition( | ||
| Vector3 startPos, | ||
| Vector3 endPos, | ||
| GameObject obj) |
Contributor
There was a problem hiding this comment.
Suggested change
| private IEnumerator SmoothTransitionPosition( | |
| Vector3 startPos, | |
| Vector3 endPos, | |
| GameObject obj) | |
| private IEnumerator SmoothTransitionPosition(Vector3 startPos, Vector3 endPos, GameObject obj) |
I find the one line definition better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple update of GameController script but this is really useful because this bool is use in other scripts to know when the animation between simulation and planification is done