-
Notifications
You must be signed in to change notification settings - Fork 8
Remove fastly dependency from trusted-server-core (PR 15) #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prk-Jr
wants to merge
20
commits into
feature/edgezero-pr14-entry-point-dual-path
Choose a base branch
from
feature/edgezero-pr15-remove-fastly-core
base: feature/edgezero-pr14-entry-point-dual-path
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6c4965b
Add PR15 implementation plan: remove fastly from core crate
prk-Jr f67be31
Move compat conversion fns to adapter, delete core compat.rs
prk-Jr c2e0776
Move geo_from_fastly from core to adapter platform
prk-Jr 25bcf99
Move BackendConfig from core to adapter backend module
prk-Jr 8303b84
Delete dead backend_name_for_url from adapter backend
prk-Jr 76087e4
Delete legacy FastlyConfigStore and FastlySecretStore from core
prk-Jr 7795e69
Remove fastly::kv_store from core consent module
prk-Jr abd1f26
Fix consent KV trait design and formatting
prk-Jr d96dbbe
Move tokio to dev-dependencies in core (test-only usage)
prk-Jr 8f40601
Remove fastly dependency from trusted-server-core
prk-Jr 9a4357c
Remove stale fastly:: references from core doc comments
prk-Jr 46704c0
Apply cargo fmt formatting fixes
prk-Jr 60611fa
Wire consent KV into auction path and remove tokio from core tests
prk-Jr 02639db
Merge feature/edgezero-pr14-entry-point-dual-path into PR15
prk-Jr d8060d3
Address PR15 review findings: diagnostic regression, header dedup, co…
prk-Jr 3a53f33
Resolve PR15 consent and backend review findings
prk-Jr 54d191b
Merge feature/edgezero-pr14-entry-point-dual-path into feature/edgeze…
prk-Jr 2e128f7
Merge feature/edgezero-pr14-entry-point-dual-path into PR15
prk-Jr f5b7097
fix cargo fmt
prk-Jr 725ccdc
Resolve PR review suggestions
prk-Jr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌱 seedling —
trusted-server-js = { path = "../js" }is in the adapter's[dependencies]but never imported by adapter source. The adapter callshandle_tsjs_dynamicfromtrusted_server_core, which already pulls trusted-server-js transitively. Likely a leftover from PR15's adapter-side surgery. Removing this line should be a no-op for build/test and trims the dep graph.