Add missing migration for Partners & AssignedReviewers#4804
Merged
Conversation
Member
|
Running this: I get this error: |
Member
|
I think we can make changes to The few system that have applied it likely do not have this edgecase so do not need fixes. |
Contributor
Author
|
Yeah I had to manually remove 0028_remove_partner_group from the database to get this in but this makes a little more sense, I think it should be good to go! |
692c0b1 to
a0d04d0
Compare
frjo
approved these changes
Apr 12, 2026
Member
|
@wes-otf The new function was never run so I did that minor fix. Also fixed so apps.get_model() always was used. Works well in my testing now. I think we can do a new release when this is merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4790. I missed an edge case where an
AssignedReviewerwas also a Partner, in which the migrations would fail as thetypeattribute is protected in the model. This moves all types of partner to reviewer.Test Steps
AssignedReviewerswith type of partner get migrated to reviewer and that all migrations pass successfully.