Add NamedParameter to JinjavaFunctions allowlist group#1317
Merged
jasmith-hs merged 1 commit intomasterfrom May 7, 2026
Merged
Add NamedParameter to JinjavaFunctions allowlist group#1317jasmith-hs merged 1 commit intomasterfrom
jasmith-hs merged 1 commit intomasterfrom
Conversation
NamedParameter needs to be allowlisted so that when a NamedParameter object is accessed through the EL resolver (e.g. from context), the return type and method validators don't reject it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rewaddell
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
NamedParameterto theJinjavaFunctionsallowlist group so that NamedParameter objects are accepted by both the return type and method validators when accessed through the EL resolver. Without this, a NamedParameter looked up from context would be rejected by the allowlist validators, preventing property access like.nameand.value.Authored by Claude Code
BRAVE
Backwards Compatibility
Additive-only change — adds a new class to an existing allowlist. No existing behavior is modified.
Rollout and Rollback Plan
Standard deploy. Rollback by reverting the commit.
Automated Testing
Tests added:
itResolvesNamedParameterNameThroughAllowlist— verifies{{ np.name }}resolves through the allowlistitResolvesNamedParameterValueThroughAllowlist— verifies{{ np.value }}resolves through the allowlistVerification
Unit tests pass locally. Both tests exercise the full rendering path with allowlist validators enabled via
BaseJinjavaTest.Expect Dependencies to Fail
No downstream breakage expected — this is purely additive.
REVIEWERS: Please review both the code changes and the answers above, and validate that they match the expectations for BRAVE