Skip to content

ci: bump both AI-review caller pins to ai-review-prompts@128656e4#82

Merged
heskew merged 1 commit into
mainfrom
ci/bump-ai-review-prompts-d9274252
May 12, 2026
Merged

ci: bump both AI-review caller pins to ai-review-prompts@128656e4#82
heskew merged 1 commit into
mainfrom
ci/bump-ai-review-prompts-d9274252

Conversation

@heskew
Copy link
Copy Markdown
Member

@heskew heskew commented May 12, 2026

Summary

Symmetric pin across claude-review.yml and gemini-review.yml — both now reference ai-review-prompts@128656e4. Easier to audit "are we current?" without per-file checks, and matches the "single pin per repo upgrade motion" the caller comment already promises.

What each caller picks up

claude-review.yml (was @3278ce4e → @128656e4)

  • Shared-script refactor: provider-agnostic find-prior-review-comment.sh + log-review-to-ai-review-log.sh with explicit MARKER / MODEL env vars. Behavior for Claude is unchanged — PROVIDER_LABEL stays empty so the legacy title format is preserved.
  • New **Run:** link in the ai-review-log issue body (one click to the workflow run, where token usage / estimated cost is visible).
  • authorize-claude-workflow.shauthorize-ai-workflow.sh rename, handled inside the reusable (consumer caller doesn't reference the script directly).
  • Auth-gate validator now pattern-based (covers both providers' reusables automatically).

gemini-review.yml (was @9471cd80 → @128656e4)

  • Architectural fix: Gemini's review is now posted by the workflow on the agent's behalf, since run-gemini-cli's single-shot mode doesn't give the agent shell tools to call gh pr comment directly.
  • Output-name fix: post step now references the action's caller-facing output (summary) instead of the action's internal step output (gemini_response). Without this fix the post step was silently skipped — discovered on this PR's first run, after the artifact upload addition surfaced the agent's actual response (which was correct all along).
  • Artifact upload enabled on the Gemini step for post-mortem visibility.
  • Default model: gemini-3-flash-preview — Google's current-gen mid-tier Flash. No model: override needed.

Expected first-run quirk

The Claude step on this PR's branch will fail with a GitHub-side App-token 401 from claude-code-action's workflow validation ("workflow file must exist and have identical content to the version on the default branch"). This is a known gotcha for workflow-modifying PRs and the message itself says to ignore it. After this PR merges, subsequent PRs review normally.

Test plan

  • Merge
  • Push something on PR release: 2.0.0-alpha.2 #80 to retrigger reviewers — first real dual-provider datapoint with all fixes in place
  • Confirm:
    • Claude posts as claude[bot] with <!-- claude-review:v1 --> (resumes normal operation)
    • Gemini posts as github-actions[bot] with <!-- gemini-review:v1 --> (was always silently skipped before)
    • Two log issues land in the review-log repo, one per provider, with correct titles + labels

🤖 Generated with Claude Code

@heskew heskew requested a review from a team as a code owner May 12, 2026 19:14
Symmetric pin across `claude-review.yml` and `gemini-review.yml`.
Both callers now reference the same ai-review-prompts SHA — easier
to audit "are we current?" without per-file checks, and matches
the "single pin per repo upgrade motion" the caller comment
already promises.

`claude-review.yml` (was @3278ce4e, post-#20) → @128656e4.
Picks up:
- Shared-script refactor (#22): provider-agnostic
  find-prior-review-comment.sh + log-review-to-ai-review-log.sh
  with explicit MARKER / MODEL env vars. Behavior for Claude
  unchanged (PROVIDER_LABEL stays empty → legacy title format
  preserved). New body fields: `**Run:**` link to the workflow
  run page (visible in ai-review-log entries).
- authorize-claude-workflow.sh → authorize-ai-workflow.sh rename
  (handled inside the reusable; consumer caller untouched).
- Auth-gate validator generalization to pattern-based glob.

`gemini-review.yml` (was @9471cd80, post-#22) → @128656e4.
Picks up:
- Architectural fix (#24): workflow posts the Gemini response
  via a new post step, since run-gemini-cli's single-shot mode
  doesn't give the agent tool access to call `gh pr comment`
  itself.
- Output-name fix (#25): post step now references the action's
  caller-facing output (`summary`) instead of the action's
  internal step output (`gemini_response`). Without this fix
  the post step was always skipped silently — discovered on
  this PR's first run (after #24's artifact-upload addition
  let us see the agent's actual response in stdout.log).
- Artifact upload enabled on the Gemini step for post-mortem
  visibility.
- Default model flipped to `gemini-3-flash-preview` (#23) —
  Google's current-gen mid-tier Flash, the apples-to-apples
  peer of Claude Sonnet 4.6. No `model:` override needed here.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@heskew heskew force-pushed the ci/bump-ai-review-prompts-d9274252 branch from 16529ec to ca6385a Compare May 12, 2026 19:36
@heskew heskew changed the title ci: bump both AI-review caller pins to ai-review-prompts@d9274252 ci: bump both AI-review caller pins to ai-review-prompts@128656e4 May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Reviewed; no blockers found.

@heskew heskew merged commit bde8069 into main May 12, 2026
10 of 12 checks passed
@heskew heskew deleted the ci/bump-ai-review-prompts-d9274252 branch May 12, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant