fix(deps): update dependency @google-cloud/firestore to v6 [security]#659
Conversation
|
/gcbrun |
There was a problem hiding this comment.
Code Review
This pull request updates the @google-cloud/firestore dependency from version 5 to version 6 across several package.json files. A critical compatibility issue was identified in sessions/package.json, where upgrading Firestore to v6 requires a corresponding upgrade of @google-cloud/connect-firestore to version 3.0.0 to prevent breaking changes and ensure the session store remains functional.
| "dependencies": { | ||
| "@google-cloud/connect-firestore": "^2.0.0", | ||
| "@google-cloud/firestore": "^5.0.0", | ||
| "@google-cloud/firestore": "^6.2.0", |
There was a problem hiding this comment.
Upgrading @google-cloud/firestore to v6 while keeping @google-cloud/connect-firestore at v2.x is likely to cause compatibility issues. Firestore v6 introduced several breaking changes, including the separation of v1 and v1beta1 protos, which are not supported by older versions of the session store. @google-cloud/connect-firestore v3.0.0 was specifically released to provide compatibility with Firestore v6. It is highly recommended to upgrade @google-cloud/connect-firestore to ^3.0.0 alongside this change to ensure the application remains functional.
e7632af to
5708a7a
Compare
|
/gcbrun |
5708a7a to
b307bce
Compare
|
/gcbrun |
b307bce to
08fbedf
Compare
|
/gcbrun |
08fbedf to
c314657
Compare
|
/gcbrun |
This PR contains the following updates:
^5.0.0→^6.2.0Logging of the firestore key within nodejs-firestore
CVE-2023-6460 / GHSA-4g6q-77j7-vvjc
More information
Details
A potential logging of the firestore key via logging within nodejs-firestore exists - Developers who were logging objects through this._settings would be logging the firestore key as well potentially exposing it to anyone with logs read access. We recommend upgrading to version 6.1.0 to avoid this issue
Severity
CVSS:3.1/AV:L/AC:H/PR:H/UI:R/S:U/C:H/I:N/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
googleapis/google-cloud-node (@google-cloud/firestore)
v6.2.0Compare Source
Features
Bug Fixes
v6.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
Build System
5.0.2 (2022-01-07)
Bug Fixes
5.0.1 (2021-12-02)
Bug Fixes
v5.0.2Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.