Skip to content

fix: guard against undefined text in recommendations causing toLowerC… #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
web3-jeff merged 1 commit into from
Apr 14, 2026
Merged

fix: guard against undefined text in recommendations causing toLowerC… #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion skills/agentguard/scripts/checkup-report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,8 @@ function generateReport(data) {
autoRecs.push({ severity: 'LOW', text: 'Enable auto-scan on session start: export AGENTGUARD_AUTO_SCAN=1', zh: '启用会话启动时自动扫描：export AGENTGUARD_AUTO_SCAN=1' });

// Merge: user recs first, then auto recs (dedup by text similarity)
const allRecs = [...recommendations];
// Guard against malformed entries where text may be undefined (#37)
const allRecs = recommendations.filter(r => r && typeof r.text === 'string');
for (const ar of autoRecs) {
if (!allRecs.some(r => r.text.toLowerCase().includes(ar.text.slice(0, 30).toLowerCase()))) {
allRecs.push(ar);
Expand Down
Loading