chore: add Genetec Web Player projects to solution#178
Open
alafleur-genetec wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Samples/Genetec.Dap.CodeSamples.sln solution to include Genetec Web Player sample projects and organize them under a new “Genetec Web Player” solution folder.
Changes:
- Added a new solution folder: Genetec Web Player
- Added three projects to the solution: GwpDesktopPlayerSample, GwpMinimalApiSample, GwpRazorPagesSample
- Added configuration/build mappings and nested-project entries to place the projects under the new solution folder
Comments suppressed due to low confidence (2)
Samples/Genetec.Dap.CodeSamples.sln:1499
- The solution’s *_NET481 configurations currently build this project (ActiveCfg/Build.0 point to Debug/Release). Since this project targets only net8.0, building the solution in Debug_NET481/Release_NET481 will still attempt to compile it and can break NET481-only build environments. Consider removing the Build.0 entries for the *_NET481 solution configurations (so it’s excluded from those builds), or update the project to support net481 / add matching Debug_NET8/Debug_NET481 configurations.
{C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Debug_NET481|Any CPU.ActiveCfg = Debug|Any CPU
{C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Debug_NET481|Any CPU.Build.0 = Debug|Any CPU
{C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Debug_NET8|Any CPU.ActiveCfg = Debug|Any CPU
{C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Debug_NET8|Any CPU.Build.0 = Debug|Any CPU
{C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Debug|Any CPU.Build.0 = Debug|Any CPU
{C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Release_NET481|Any CPU.ActiveCfg = Release|Any CPU
{C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Release_NET481|Any CPU.Build.0 = Release|Any CPU
Samples/Genetec.Dap.CodeSamples.sln:1511
- The solution’s *_NET481 configurations currently build this project (ActiveCfg/Build.0 point to Debug/Release). Since this project targets only net8.0, building the solution in Debug_NET481/Release_NET481 will still attempt to compile it and can break NET481-only build environments. Consider removing the Build.0 entries for the *_NET481 solution configurations (so it’s excluded from those builds), or update the project to support net481 / add matching Debug_NET8/Debug_NET481 configurations.
{F6FEAE2D-E83E-FC41-0209-C18D1E6DB7C0}.Debug_NET481|Any CPU.ActiveCfg = Debug|Any CPU
{F6FEAE2D-E83E-FC41-0209-C18D1E6DB7C0}.Debug_NET481|Any CPU.Build.0 = Debug|Any CPU
{F6FEAE2D-E83E-FC41-0209-C18D1E6DB7C0}.Debug_NET8|Any CPU.ActiveCfg = Debug|Any CPU
{F6FEAE2D-E83E-FC41-0209-C18D1E6DB7C0}.Debug_NET8|Any CPU.Build.0 = Debug|Any CPU
{F6FEAE2D-E83E-FC41-0209-C18D1E6DB7C0}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{F6FEAE2D-E83E-FC41-0209-C18D1E6DB7C0}.Debug|Any CPU.Build.0 = Debug|Any CPU
{F6FEAE2D-E83E-FC41-0209-C18D1E6DB7C0}.Release_NET481|Any CPU.ActiveCfg = Release|Any CPU
{F6FEAE2D-E83E-FC41-0209-C18D1E6DB7C0}.Release_NET481|Any CPU.Build.0 = Release|Any CPU
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1481
to
+1493
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Debug_NET481|Any CPU.Build.0 = Debug|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Debug_NET8|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Debug_NET8|Any CPU.Build.0 = Debug|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Release_NET481|Any CPU.ActiveCfg = Release|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Release_NET481|Any CPU.Build.0 = Release|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Release_NET8|Any CPU.ActiveCfg = Release|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Release_NET8|Any CPU.Build.0 = Release|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {1CEB044B-B52B-25F4-1C08-168EAFD4C5A6}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Debug_NET481|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {C7C206CB-5A5E-84E9-9A3E-23FA0D563E7F}.Debug_NET481|Any CPU.Build.0 = Debug|Any CPU |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Visual Studio solution file
Genetec.Dap.CodeSamples.slnto add new sample projects related to the Genetec Web Player, along with their build configurations and solution folder organization.Addition of new Genetec Web Player sample projects:
Genetec Web Playerand included three new sample projects:GwpDesktopPlayerSample,GwpMinimalApiSample, andGwpRazorPagesSampleto the solution.Build configuration updates:
Solution folder organization:
Genetec Web Playersolution folder for better organization within the solution explorer.