fix: align sample AssemblyName with folder/project name#176
Closed
alafleur-genetec wants to merge 2 commits into
Closed
fix: align sample AssemblyName with folder/project name#176alafleur-genetec wants to merge 2 commits into
alafleur-genetec wants to merge 2 commits into
Conversation
DiagnosticServerSample produced DiagnosticServer.exe and FileCryptingManagerSample produced FileCryptingManager.exe. Every other sample uses the ...Sample suffix matching its folder.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the produced assembly/executable names of two sample projects with the established convention that sample binaries include the ...Sample suffix matching their folder/project name.
Changes:
- Update
DiagnosticServerSampleoutput assembly name fromDiagnosticServertoDiagnosticServerSample. - Update
FileCryptingManagerSampleoutput assembly name fromFileCryptingManagertoFileCryptingManagerSample.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Samples/Platform SDK/DiagnosticServerSample/DiagnosticServerSample.csproj | Renames <AssemblyName> so the sample builds DiagnosticServerSample.exe (consistent with folder/project naming). |
| Samples/Media SDK/FileCryptingManagerSample/FileCryptingManagerSample.csproj | Renames <AssemblyName> so the sample builds FileCryptingManagerSample.exe (consistent with folder/project naming). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The Copyright element had a stray Latin-1 0xa9 byte for the copyright symbol in an otherwise UTF-8 file. Replaced with proper UTF-8 (0xc2 0xa9) so the symbol renders correctly in editors and tooling.
Member
Author
|
Closing this PR because its assembly-name fixes have been folded into #174, which now covers the sample project/folder/assembly naming cleanup in one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiagnosticServerSampleproducedDiagnosticServer.exe(folder:DiagnosticServerSample)FileCryptingManagerSampleproducedFileCryptingManager.exe(folder:FileCryptingManagerSample)Every other sample uses the
...Samplesuffix matching its folder. Aligning these two restores the convention.