Figure.pygmtlogo: Add tests for the circular, black/white PyGMT logo#4625
Figure.pygmtlogo: Add tests for the circular, black/white PyGMT logo#4625
Conversation
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded imagesModified images
Report last updated at commit f7344d2 |
seisman
force-pushed
the
pygmtlogo-circle-blackwhite
branch
from
17f6c86 to
f7344d2
Compare
| y=0, | ||
| style=f"{symbol}{size_shape + thick_shape}c", | ||
| pen=f"1p,{color_dark}", | ||
| pen=f"{thick_comp / 2.0}c,{color_bg}", |
There was a problem hiding this comment.
color_bg is the same as color_dark in this case. I prefer not to use color_dark because it's not used after line 70.
The outline thickness 1p is not ideal, because it doesn't scale well with size. Here I set the thickness to "half of the compass line".
Below is the high-resolution version of the black/white dark logo.
There was a problem hiding this comment.
But wait maybe better to use thick_gap here for consistency.
yvonnefroehlich
left a comment
yvonnefroehlich
left a comment
There was a problem hiding this comment.
Maybe change the title to: "Figure.pygmtlogo: Test the ...".
seisman
changed the title
seisman
changed the title
Done. |
| y=0, | ||
| style=f"{symbol}{size_shape + thick_shape}c", | ||
| pen=f"1p,{color_dark}", | ||
| pen=f"{thick_comp / 2.0}c,{color_bg}", |
There was a problem hiding this comment.
But wait maybe better to use thick_gap here for consistency.
| y=0, | ||
| style=f"{symbol}{size_shape + thick_shape}c", | ||
| pen=f"1p,{color_dark}", | ||
| pen=f"{thick_comp / 2.0}c,{color_bg}", |
There was a problem hiding this comment.
| pen=f"{thick_comp / 2.0}c,{color_bg}", | |
| pen=f"{thick_gap}c,{color_bg}", |
There was a problem hiding this comment.
thick_gap controls the spacing between letter M and G. It is noticeably thicker than the gaps surrounding the vertical red bar at the top.
Currently, thick_comp = thick_shape/3 and thick_gap=thick_shape/4. Actually, I'm thinking about if we should set thick_gap to thick_comp / 2.0.
| thick_gap=thick_shape/3 | thick_gap = thick_comp/2.0 |
|---|---|
 |
 |
There was a problem hiding this comment.
thick_gapcontrols the spacing between letter M and G. It is noticeably thicker than the gaps surrounding the vertical red bar at the top.
I am sorry, the / 2.0 is still needed.
What I like is that the thickness of this outline is identical to the gap between the red line and red arrowhead and the blue shape.
Currently,
thick_comp = thick_shape/3andthick_gap=thick_shape/4. Actually, I'm thinking about if we should setthick_gaptothick_comp / 2.0.
I believe (did not search in the initial PR) we had thick_gap = thick_comp / 2.0 at the beginning, and I increased the value to make sure the gap between the letters G and M is still clearly visible for a small size of the logo.
There was a problem hiding this comment.
What I like is that the thickness of this outline is identical to the gap between the red line and red arrowhead and the blue shape.
This gap between the red line and the blue shape is exactly thick_comp / 2.0, not thick_gap.
There was a problem hiding this comment.
I increased the value to make sure the gap between the letters G and M is still clearly visible for a small size of the logo.
It makes sense.
There was a problem hiding this comment.
What I like is that the thickness of this outline is identical to the gap between the red line and red arrowhead and the blue shape.
This gap between the red line and the blue shape is exactly
thick_comp / 2.0, notthick_gap.
OK. Then it should be fine 🙂. Seems like I confused myself with this radii.
2 participants
Finalize the circular, black/white PyGMT logo for both light/dark themes.