Skip to content

Sp26 snakes tale#23

Open
valentinampinedad wants to merge 14 commits into
mainfrom
sp26-snakes-tale
Open

Sp26 snakes tale#23
valentinampinedad wants to merge 14 commits into
mainfrom
sp26-snakes-tale

Conversation

@valentinampinedad
Copy link
Copy Markdown

No description provided.

@hpghsu1314
Copy link
Copy Markdown
Contributor

hpghsu1314 commented May 2, 2026

In your checks you have the databases (.db files) for the game. This should not happen. In fact, I believe you have two copy of snakestale, one in games/src/games and one in the outermost directory. Please remove all the .db files outside and remove the incorrect copy. All source code that you create for a game should be in games/src/games. I will do a code review after these changes are done.

@valentinampinedad
Copy link
Copy Markdown
Author

Just committed the fixes :)

@hpghsu1314
Copy link
Copy Markdown
Contributor

uv.lock is in staged changes right now. Please run the following in your branch:
git fetch origin
git checkout origin/main -- uv.lock
git commit -m "revert uv.lock"
git push

Copy link
Copy Markdown
Member

@AEstrellaS AEstrellaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code

@hpghsu1314
Copy link
Copy Markdown
Contributor

Wait I tried pulling your code and trying to see if i can revise the history and it doesn't work. I will use your branch as the main testing branch for the problem. Please ignore the commits that you will see here.

Copy link
Copy Markdown
Contributor

@hpghsu1314 hpghsu1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when Uni and Uwapi are both approved.

@hpghsu1314 hpghsu1314 dismissed AEstrellaS’s stale review May 6, 2026 06:04

Commented out code deleted.

@hpghsu1314
Copy link
Copy Markdown
Contributor

image I am seeing a scene like this, which is incorrect. Please fix.

Copy link
Copy Markdown
Contributor

@hpghsu1314 hpghsu1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the above comment.

@valentinampinedad
Copy link
Copy Markdown
Author

just pushed the fix, it was in uwapi

@hpghsu1314
Copy link
Copy Markdown
Contributor

image Still incorrect. Now the white snake is broken.

Copy link
Copy Markdown
Contributor

@hpghsu1314 hpghsu1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the updated comment.

@valentinampinedad
Copy link
Copy Markdown
Author

should be fixed now, handled errors in file assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants