Skip to content

Sp26 marble circuit#22

Open
shen147258369 wants to merge 13 commits into
mainfrom
sp26-marble-circuit
Open

Sp26 marble circuit#22
shen147258369 wants to merge 13 commits into
mainfrom
sp26-marble-circuit

Conversation

@shen147258369
Copy link
Copy Markdown

Added Marble Circuit puzzle

@shen147258369 shen147258369 requested a review from AEstrellaS May 1, 2026 23:36
@AEstrellaS AEstrellaS requested a review from hpghsu1314 May 2, 2026 02:02
@hpghsu1314
Copy link
Copy Markdown
Contributor

hpghsu1314 commented May 2, 2026

I am unsure why you have lightsout solved here. Furthermore, tui.py and sqlite_database.py should not be changed. Please unstage those changes (the edits for lightsout, tui.py, and sqlite_database.py), then test locally again before pushing your changes. I will do the code review after these changes are done. Also, please translate comments to English.

Comment thread database/src/database/sqlite_database.py
Comment thread games/src/games/game_manager.py
Comment thread games/src/games/lightsout.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unstage file change

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldnt be touched, please unstage the changes

Copy link
Copy Markdown
Contributor

@hpghsu1314 hpghsu1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use simpler characters for your position string. For example, do not use ., ~, or other symbols. Your autogui position string can use whatever you want, although it would be better if it weren't also using these types of characters. Furthermore, tui.py should not be changed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldnt be touched, please unstage the changes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line character at the end of the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants