Skip to content

Add Klotski puzzle#12

Open
adokanchi wants to merge 3 commits into
GamesCrafters:mainfrom
adokanchi:klotski
Open

Add Klotski puzzle#12
adokanchi wants to merge 3 commits into
GamesCrafters:mainfrom
adokanchi:klotski

Conversation

@adokanchi
Copy link
Copy Markdown

@adokanchi adokanchi commented Apr 15, 2026

Add Klotski puzzle

AEstrellaS
AEstrellaS previously requested changes Apr 23, 2026
View reviewed changes
Comment thread games/src/games/klotski.py
Comment thread server/src/server/server.py
@adokanchi adokanchi requested a review from AEstrellaS April 30, 2026 18:52
@AEstrellaS AEstrellaS requested a review from hpghsu1314 May 2, 2026 02:02
hpghsu1314
hpghsu1314 requested changes May 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hpghsu1314 hpghsu1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes.

Comment thread games/src/games/game_manager.py Outdated
Comment thread games/src/games/game_manager.py Outdated
@adokanchi adokanchi requested a review from hpghsu1314 May 3, 2026 07:31
hpghsu1314
hpghsu1314 approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hpghsu1314 hpghsu1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge after uwapi and uni are approved, and when I have time.

@hpghsu1314 hpghsu1314 dismissed AEstrellaS’s stale review May 5, 2026 09:59

Fixes were implemented.

AEstrellaS
AEstrellaS requested changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@AEstrellaS AEstrellaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small termination

Comment thread games/src/games/klotski.py
Copy link
Copy Markdown
Member

@AEstrellaS AEstrellaS May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add end of line termination

@hpghsu1314
Copy link
Copy Markdown
Contributor

hpghsu1314 commented May 8, 2026

Please change this pull request so that you are doing it from a branch. It is quite inefficient when I need to copy your repository just to test this locally. I would like to be able to switch branches quickly to do local testing.

@AEstrellaS
Copy link
Copy Markdown
Member

AEstrellaS commented May 14, 2026

Please change this pull request so that you are doing it from a branch. It is quite inefficient when I need to copy your repository just to test this locally. I would like to be able to switch branches quickly to do local testing.

@adokanchi @by23-sudo

@adokanchi
Copy link
Copy Markdown
Author

adokanchi commented May 15, 2026

It doesn't seem that I have the proper permissions for that.

PS C:\Users\adoka\GamesmanPy> git push origin klotski
remote: Permission to GamesCrafters/GamesmanPy.git denied to adokanchi.
fatal: unable to access 'https://github.com/GamesCrafters/GamesmanPy.git/': The requested URL returned error: 403

I don't know much about how git works, so please let me know if this is an issue on my end and if there's anything I can do.

@hpghsu1314
Copy link
Copy Markdown
Contributor

hpghsu1314 commented May 16, 2026

You're using the wrong thing. It should be git@github.com:GamesCrafters/GamesmanPy.git. That should be the remote name when you type git remote -v.

@hpghsu1314
Copy link
Copy Markdown
Contributor

hpghsu1314 commented May 16, 2026

image You can add a remote by doing git remote add , which is the thing above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AEstrellaS AEstrellaS AEstrellaS requested changes

@hpghsu1314 hpghsu1314 hpghsu1314 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adokanchi @hpghsu1314 @AEstrellaS