Make scroll-wheel volume changes configurable#1814
Open
SetupCoding wants to merge 123 commits intoFile-New-Project:devfrom
Open
Make scroll-wheel volume changes configurable#1814SetupCoding wants to merge 123 commits intoFile-New-Project:devfrom
SetupCoding wants to merge 123 commits intoFile-New-Project:devfrom
Conversation
- Remove tray icon scroll subscription and handler from App.xaml.cs - Remove MouseWheel handler from VolumeSlider.cs (keep ChangePositionByAmount) - Remove MouseHook field, initialization, SetHook/UnHook, and OnMouseWheelEvent from FlyoutViewModel.cs - Remove unused _winRect field (UpdateWindowPos kept as no-op for IFlyoutViewModel interface) - Remove unused 'using EarTrumpet.Interop' and 'using EarTrumpet.Interop.Helpers' (MouseHook) - Click/drag/touch slider, hotkeys, and mute commands still work
|
|
Restore all scroll-wheel volume behavior but gate each path behind its existing or new setting: - Tray icon scroll: gated by UseScrollWheelInTray (existing, default on) - Global mouse wheel hook while flyout open: gated by UseGlobalMouseWheelHook (existing, default off) - Volume slider scroll: gated by new UseScrollWheelInSliders setting (default on) Add UseScrollWheelInSliders to AppSettings, mouse settings page VM, settings UI (checkbox), and string resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes all scroll-wheel volume adjustment behavior configurable via the Mouse Settings page, rather than always-on.
Settings
Changes
All three scroll-wheel behaviors can now be independently toggled on or off by the user. Build succeeds with 0 errors.